Reduced jacoco exclusions and added more tests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
============================================
+ Coverage 78.11% 78.32% +0.20%
- Complexity 4141 4170 +29
============================================
Files 296 296
Lines 17657 17657
Branches 1879 1879
============================================
+ Hits 13792 13829 +37
+ Misses 2971 2948 -23
+ Partials 894 880 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitgalitz
added
the
infra
ylwu-amzn
previously approved these changes
Mar 16, 2022
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
jacoco-exclusion
branch
from
52cf999 to
455a07c
Compare
ylwu-amzn
reviewed
Mar 17, 2022
| @@ -479,15 +479,16 @@ List<String> jacocoExclusions = [ | |||
| // code for configuration, settings, etc is excluded from coverage | |||
| 'org.opensearch.ad.AnomalyDetectorPlugin', | |||
|
|
|||
| // rest layer is tested in integration testing mostly, difficult to mock all of it | |||
There was a problem hiding this comment.
Refer to this PR to write unit test for REST actions opensearch-project/ml-commons#228?
There was a problem hiding this comment.
Will take a look! Will try to add those in a separate PR if thats fine
ylwu-amzn
approved these changes
Mar 17, 2022
ohltyler
approved these changes
Mar 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2505add)
amitgalitz
added a commit
that referenced
this pull request
Mar 22, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 2505add)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
This PR adds some tests to various classes that had low coverage as well as removes any unnecessary files from the
jacocoExclusionlist onbuild.gradle. We had some files there that were either already above the coverage minimum or didn’t exist anymore. Specifically.../model.*was listed and with additional testing added here and in previous PR (#335) 34 classes were taken off the exclusion list and now only 2 classes from model package are still excluded.I wont close the related issue (#424) yet since more work needs to be done addressing the TODOs, potentially reducing coverage minimums and finishing rest of
modelpackage testing.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.