Remove duplicate icon on external links #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
kaituo
approved these changes
Dec 22, 2022
ohltyler
approved these changes
Dec 22, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed additional popout icon on all external links with
target="_blank". According to EUI docs that automatically sets the link to external which adds the popout icon on its own https://eui.elastic.co/v34.6.0/#/navigation/link. I also tested this by running a cluster.I also ran
yarn prettier --write ./which is the reason for some of the unrelated formatting changes.Even though AD main CI is working I was having problems running it locally so made the change to 2.x and will forward port (I also made an issue on opensearch-build for a potential forward-port bot opensearch-project/opensearch-build#2978)
Issues Resolved
#362
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.