Use strong password in security test (#933) #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use strong password in security test Signed-off-by: bowenlan-amzn <[email protected]> * Update PR tempate Signed-off-by: bowenlan-amzn <[email protected]> * Update more password Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi and
rishabhmaurya
as code owners
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
============================================
+ Coverage 74.74% 74.93% +0.19%
Complexity 111 111
============================================
Files 141 141
Lines 8263 8263
Branches 1206 1206
============================================
+ Hits 6176 6192 +16
+ Misses 1477 1458 -19
- Partials 610 613 +3 |
lezzago
approved these changes
Jun 19, 2023
|
It seems like some tests are failing through security. This will need to be looked at for the root cause. It should be unrelated to this PR. |
lezzago
approved these changes
Jun 19, 2023
eirsep
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Backport #933
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.