Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strong password in security test #933

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented May 24, 2023

Issue #, if available:

Description of changes:

This change is to accommodate security plugin change opensearch-project/security#2784

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn
Copy link
Member Author

Seems to me the security test failure is because notification is not part of the docker image of 2.8.0

@lezzago lezzago marked this pull request as ready for review June 2, 2023 00:23
@lezzago lezzago changed the base branch from 2.x to main June 2, 2023 00:26
@lezzago lezzago changed the base branch from main to 2.x June 2, 2023 00:26
@eirsep eirsep merged commit 43754be into opensearch-project:2.x Jun 2, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-933-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43754bedfcfeb26a367a4216bf405da866703d0e
# Push it to GitHub
git push --set-upstream origin backport/backport-933-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-933-to-main.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
* Use strong password in security test

Signed-off-by: bowenlan-amzn <[email protected]>

* Update PR tempate

Signed-off-by: bowenlan-amzn <[email protected]>

* Update more password

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 43754be)
lezzago pushed a commit that referenced this pull request Jun 2, 2023
* Use strong password in security test

Signed-off-by: bowenlan-amzn <[email protected]>

* Update PR tempate

Signed-off-by: bowenlan-amzn <[email protected]>

* Update more password

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
(cherry picked from commit 43754be)

Co-authored-by: bowenlan-amzn <[email protected]>
bowenlan-amzn added a commit to bowenlan-amzn/alerting that referenced this pull request Jun 2, 2023
* Use strong password in security test

Signed-off-by: bowenlan-amzn <[email protected]>

* Update PR tempate

Signed-off-by: bowenlan-amzn <[email protected]>

* Update more password

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
eirsep pushed a commit that referenced this pull request Jun 19, 2023
* Use strong password in security test
* Update PR tempate
* Update more password
---------

Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants