[Backport 2.7] revert to deleting monitor metadata after deleting doc level queries to fix delete monitor regression. #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…to fix regression. Metadata is required for correct query index clean up (#931) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5e2312d)
Codecov Report
@@ Coverage Diff @@
## 2.7 #937 +/- ##
============================================
+ Coverage 76.66% 76.69% +0.03%
Complexity 116 116
============================================
Files 125 125
Lines 7221 7253 +32
Branches 1049 1049
============================================
+ Hits 5536 5563 +27
- Misses 1155 1158 +3
- Partials 530 532 +2
|
eirsep
approved these changes
May 25, 2023
sbcd90
approved these changes
May 25, 2023
|
CI failing due to fix pending review in #934. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5e2312d from #931