revert to deleting monitor metadata after deleting doc level queries to fix delete monitor regression. #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
sbcd90
approved these changes
May 24, 2023
…to fix regression. Metadata is required for correct query index clean up Signed-off-by: Surya Sashank Nistala <[email protected]>
lezzago
approved these changes
May 25, 2023
|
#934 contains a change which will fix the mapping for findings in alerting plugin. But this PR also is required to be merged in with CI failing as this has a bug fix for the failing workflow Once both PRs are merged the test workflow would be fixed fully. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
…to fix regression. Metadata is required for correct query index clean up (#931) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5e2312d)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
…to fix regression. Metadata is required for correct query index clean up (#931) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5e2312d)
eirsep
added a commit
that referenced
this pull request
May 25, 2023
…to fix regression. Metadata is required for correct query index clean up (#931) (#937) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5e2312d) Co-authored-by: Surya Sashank Nistala <[email protected]>
eirsep
added a commit
that referenced
this pull request
May 25, 2023
…to fix regression. Metadata is required for correct query index clean up (#931) (#936) Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5e2312d) Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Metadata is required for correct query index clean up during monitor deletion. Reverted to deleting monitor metadata after deleting doc level queries to fix regression.