[Backport 2.x] Overriding defaultTitle with subject for SNS notifications #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2)
Codecov Report
@@ Coverage Diff @@
## 2.x #723 +/- ##
============================================
+ Coverage 76.05% 76.20% +0.15%
Complexity 116 116
============================================
Files 124 124
Lines 6593 6593
Branches 976 976
============================================
+ Hits 5014 5024 +10
+ Misses 1084 1072 -12
- Partials 495 497 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lezzago
approved these changes
Jan 4, 2023
eirsep
approved these changes
Jan 6, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Jun 6, 2023
…h-project#708) (opensearch-project#723) * Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2) Co-authored-by: uroskarama <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 88536b2 from #708