-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overriding defaultTitle with subject for SNS notifications #708
Overriding defaultTitle with subject for SNS notifications #708
Conversation
Signed-off-by: uros <[email protected]>
3a894c5
to
b7aab3b
Compare
…n fix Signed-off-by: uros <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
============================================
+ Coverage 76.11% 76.31% +0.20%
Complexity 116 116
============================================
Files 124 124
Lines 6618 6619 +1
Branches 982 982
============================================
+ Hits 5037 5051 +14
+ Misses 1083 1067 -16
- Partials 498 501 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2)
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2)
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2)
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2) Co-authored-by: uroskarama <[email protected]>
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2) Co-authored-by: uroskarama <[email protected]>
* Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2) Co-authored-by: uroskarama <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-708-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88536b233c56d687ae61b7c31b69b883b7b1affe
# Push it to GitHub
git push --set-upstream origin backport/backport-708-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
…h-project#708) (opensearch-project#723) * Overriding defaultTitle with subject for SNS notifications Signed-off-by: uros <[email protected]> * Overriding defaultTitle with subject for SNS notifications - condition fix Signed-off-by: uros <[email protected]> Signed-off-by: uros <[email protected]> (cherry picked from commit 88536b2) Co-authored-by: uroskarama <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Issue #, if available: 578
Description of changes:
Using subject instead of defaultTitle if possible
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.