Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix distribution builds #1637

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix distribution builds #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sample-remote-monitor-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ task integTest(type: RestIntegTestTask) {
testClassesDirs = sourceSets.test.output.classesDirs
classpath = sourceSets.test.runtimeClasspath

if (System.getProperty("https") == null || System.getProperty("https") == "false") {
if (!isSnapshot) {
filter {
includeTestsMatching "org.opensearch.alerting.SampleRemoteMonitorIT"
excludeTestsMatching "org.opensearch.alerting.SampleRemoteMonitorIT"
}
}
}
Expand Down
16 changes: 16 additions & 0 deletions ...ote-monitor-plugin/src/test/java/org/opensearch/alerting/SampleRemoteMonitorPluginIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

package org.opensearch.alerting;

import org.junit.Assert;
import org.opensearch.test.OpenSearchIntegTestCase;

public class SampleRemoteMonitorPluginIT extends OpenSearchIntegTestCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this file for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was troubleshooting a bit last week, I recall seeing that the build would fail when using excludeTestsMatching and no test files matching the **/*IT.class pattern. I suspect that's why he included this dummy test; so there would always be a test that matches.


public void testDummy() {
Assert.assertTrue(true);
}
}
Loading