Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix distribution builds #1637

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Aug 5, 2024

Issue #, if available:
#1617

Description of changes:
fix distribution builds

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <[email protected]>

update fix

Signed-off-by: Subhobrata Dey <[email protected]>

add a dummy test

Signed-off-by: Subhobrata Dey <[email protected]>
import org.junit.Assert;
import org.opensearch.test.OpenSearchIntegTestCase;

public class SampleRemoteMonitorPluginIT extends OpenSearchIntegTestCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this file for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was troubleshooting a bit last week, I recall seeing that the build would fail when using excludeTestsMatching and no test files matching the **/*IT.class pattern. I suspect that's why he included this dummy test; so there would always be a test that matches.

@riysaxen-amzn riysaxen-amzn merged commit c61c925 into opensearch-project:main Aug 5, 2024
17 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2024
update fix

add a dummy test

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit c61c925)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 5, 2024
update fix

add a dummy test

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit c61c925)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Aug 5, 2024
update fix

add a dummy test


(cherry picked from commit c61c925)

Signed-off-by: Subhobrata Dey <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90 added a commit to sbcd90/alerting that referenced this pull request Aug 5, 2024
update fix



add a dummy test

Signed-off-by: Subhobrata Dey <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.17
# Create a new branch
git switch --create backport-1637-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c61c9254f9837b06120ac00ae786a3ca204f6394
# Push it to GitHub
git push --set-upstream origin backport-1637-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport-1637-to-2.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants