-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Composite monitors #614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * new columns with deletion modal for monitors list; added condition column to triggers Signed-off-by: Amardeepsingh Siglani <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * auto add cinditions when associated monitor is selected Signed-off-by: Jovan Cvetkovic <[email protected]> * getting associated monitors count Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux updates Signed-off-by: Amardeepsingh Siglani <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * integrated all apis; monitor deletion added Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed delete modal Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed ux issues from bug bash Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed UX feedback Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed monitor service Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed build error; schedule Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments; changed description texts Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed commented code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb2ed74)
lezzago
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #614 +/- ##
==========================================
- Coverage 51.97% 50.00% -1.98%
==========================================
Files 220 231 +11
Lines 5866 6502 +636
Branches 847 925 +78
==========================================
+ Hits 3049 3251 +202
- Misses 2814 3248 +434
Partials 3 3 |
amsiglan
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bb2ed74 from #611