Composite monitors #611

amsiglan · 2023-07-11T06:04:47Z

Description

This PR adds a new monitor type - Composite monitor which provides user with ability to combine existing monitors using trigger conditions and generate alerts when the trigger conditions are satisfied.

Issues Resolved

#610

Check List

[] New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jovan Cvetkovic <[email protected]>

…-dashboards-plugin into composite_monitors

Signed-off-by: Jovan Cvetkovic <[email protected]>

…-dashboards-plugin into composite_monitors

Signed-off-by: Jovan Cvetkovic <[email protected]>

…lumn to triggers Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

public/pages/CreateTrigger/containers/CreateTrigger/utils/constants.js

public/pages/Dashboard/containers/Dashboard.js

server/services/AlertService.js

lezzago · 2023-07-11T17:39:50Z

Also we might want to consolidate the terms composite and workflows

Signed-off-by: Amardeepsingh Siglani <[email protected]>

codecov · 2023-07-11T18:52:55Z

Codecov Report

Merging #611 (e2204d5) into main (18bdd05) will decrease coverage by 1.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   51.97%   50.00%   -1.98%     
==========================================
  Files         220      231      +11     
  Lines        5866     6502     +636     
  Branches      847      925      +78     
==========================================
+ Hits         3049     3251     +202     
- Misses       2814     3248     +434     
  Partials        3        3

see 48 files with indirect coverage changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>

cypress/integration/composite_level_monitor_spec.js

Signed-off-by: Amardeepsingh Siglani <[email protected]>

AWSHurneyt

Most of my comments are non-blocking; so I think it would be fine to create a github issue to track any of those changes for a future release.

cypress/fixtures/sample_composite_level_monitor.json

AWSHurneyt · 2023-07-11T20:21:12Z

cypress/integration/composite_level_monitor_spec.js

+      cy.contains('Create monitor', { timeout: 20000 });
+
+      // Go to create monitor page
+      cy.contains('Create monitor').click({ force: true });


Non-blocking nitpick: This could probably be simplified to:

cy.contains('Create monitor', { timeout: 20000 }).click({ force: true });

Let me do it in follow up PR

AWSHurneyt · 2023-07-11T21:11:49Z

cypress/integration/composite_level_monitor_spec.js

+      const body = {
+        size: 200,
+        query: {
+          match_all: {},
+        },
+      };
+      cy.request({
+        method: 'GET',
+        url: `${Cypress.env('opensearch')}${API.MONITOR_BASE}/_search`,
+        failOnStatusCode: false, // In case there is no alerting config index in cluster, where the status code is 404
+        body,
+      }).then((response) => {
+        if (response.status === 200) {
+          const monitors = response.body.hits.hits;
+          const createdMonitor = _.find(
+            monitors,
+            (monitor) => monitor._source.name === SAMPLE_VISUAL_EDITOR_MONITOR
+          );
+          if (createdMonitor) {
+            cy.visit(
+              `${Cypress.env('opensearch_dashboards')}/app/${PLUGIN_NAME}#/monitors/${
+                createdMonitor._id
+              }?action=update-monitor&type=workflow`
+            );
+          } else {
+            cy.log('Failed to get created monitor ', SAMPLE_VISUAL_EDITOR_MONITOR);
+            throw new Error(`Failed to get created monitor ${SAMPLE_VISUAL_EDITOR_MONITOR}`);
+          }
+        } else {
+          cy.log('Failed to get all monitors.', response);
+        }
+      });


Non-blocking, but would this be better as a custom command we add in our cypress/support/commands.js?

AWSHurneyt · 2023-07-11T21:38:43Z

public/pages/CreateMonitor/components/AssociateMonitors/AssociateMonitors.js

+          }
+          target="_blank"
+        >
+          Learn more.


Nitpick: Do we typically have a . in the Learn more link text? A quick search suggests we don't typically include it https://github.com/search?q=repo%3Aopensearch-project%2Falerting-dashboards-plugin+%22Learn+more%22&type=code

Let me fix this in a follow up PR

AWSHurneyt · 2023-07-11T21:47:01Z

public/pages/CreateMonitor/components/AssociateMonitors/components/MonitorsList.js

+  const setFormikValues = (selected, monitorIdx, form) => {
+    const associatedMonitors = _.get(
+      values,
+      'associatedMonitors',


Non-blocking nitpick: Noticed you had the formikValueName const above which could probably be used here.

public/pages/Dashboard/utils/helpers.js

AWSHurneyt · 2023-07-11T23:27:04Z

public/pages/MonitorDetails/containers/Triggers/Triggers.js

      default:
        return trigger[TRIGGER_TYPE.QUERY_LEVEL];
    }
  });
 }

+const expressionsToCondition = (expressions) => {
+  const conditionMap = {


Non-blocking nitpick: I think I've seen this map in a few places. Could be worthwhile to extract it into a helper file somewhere.

AWSHurneyt · 2023-07-11T23:30:43Z

public/pages/MonitorDetails/containers/Triggers/Triggers.js

+      this.setState({ items: triggers });
+    } else {
+      this.setState({ items: triggers });
+    }


Non-blocking nitpick: It looks like this.setState({ items: triggers }); is called in both the if/else blocks; so it could be simplified by just moving it out of the block.

AWSHurneyt · 2023-07-11T23:38:22Z

public/utils/helpers.js

@@ -47,6 +47,22 @@ export const inputLimitText = (
  );
 };

+export async function deleteMonitor(monitor, httpClient, notifications) {
+  const { id, version } = monitor;
+  const poolType = monitor.item_type === 'composite' ? 'workflows' : 'monitors';


Non-blocking nitpick: It may be worthwhile to compile an exhaustive list of item_types in a constant somewhere.

AWSHurneyt · 2023-07-11T23:40:57Z

server/services/MonitorService.js

@@ -137,7 +238,10 @@ export default class MonitorService {
      }

      const { callAsCurrentUser } = await this.esDriver.asScoped(req);
-      const updateResponse = await callAsCurrentUser('alerting.updateMonitor', params);
+      const updateResponse = await callAsCurrentUser(
+        `alerting.${type === 'workflow' ? 'updateWorkflow' : 'updateMonitor'}`,


Non-blocking nitpick: It may be worthwhile to compile an exhaustive list of types in a constant somewhere.

amsiglan · 2023-07-12T00:07:26Z

All nitpicks will be addressed in follow up PR

* [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * new columns with deletion modal for monitors list; added condition column to triggers Signed-off-by: Amardeepsingh Siglani <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * auto add cinditions when associated monitor is selected Signed-off-by: Jovan Cvetkovic <[email protected]> * getting associated monitors count Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux updates Signed-off-by: Amardeepsingh Siglani <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * integrated all apis; monitor deletion added Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed delete modal Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed ux issues from bug bash Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed UX feedback Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed monitor service Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed build error; schedule Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments; changed description texts Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed commented code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb2ed74)

* [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Add composite monitor type #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * new columns with deletion modal for monitors list; added condition column to triggers Signed-off-by: Amardeepsingh Siglani <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review #573 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Unit tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * Add visual editor callout message for advanced conditions Signed-off-by: Jovan Cvetkovic <[email protected]> * auto add cinditions when associated monitor is selected Signed-off-by: Jovan Cvetkovic <[email protected]> * getting associated monitors count Signed-off-by: Amardeepsingh Siglani <[email protected]> * ux updates Signed-off-by: Amardeepsingh Siglani <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * Adds multiple triggers Signed-off-by: Jovan Cvetkovic <[email protected]> * integrated all apis; monitor deletion added Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed delete modal Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed ux issues from bug bash Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed UX feedback Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed monitor service Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed build error; schedule Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments; changed description texts Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed commented code Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit bb2ed74) Co-authored-by: Amardeepsingh Siglani <[email protected]>

jovancvetkovic3006 and others added 30 commits June 9, 2023 17:18

[FEATURE] Add composite monitor type opensearch-project#573

28b8162

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/alerting…

c068abd

…-dashboards-plugin into composite_monitors

[FEATURE] Add composite monitor type opensearch-project#573

11b5b0d

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

a8aa47a

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

83d6eb6

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

567db1d

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

f6b39fe

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

2201c0e

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

654a5f1

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

39b4d0d

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

be4b4bf

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

1792d4c

Signed-off-by: Jovan Cvetkovic <[email protected]>

Merge branch 'main' of https://github.com/opensearch-project/alerting…

e60c4ff

…-dashboards-plugin into composite_monitors

[FEATURE] Add composite monitor type opensearch-project#573

8e5723b

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

12f0e6f

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

88d7ac9

Signed-off-by: Jovan Cvetkovic <[email protected]>

[FEATURE] Add composite monitor type opensearch-project#573

11ebb8d

Signed-off-by: Jovan Cvetkovic <[email protected]>

new columns with deletion modal for monitors list; added condition co…

59ec9d1

…lumn to triggers Signed-off-by: Amardeepsingh Siglani <[email protected]>

Code review opensearch-project#573

727a692

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

bf802c1

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

475807f

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

c796666

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

2ad090a

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

bcd173b

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

8a02403

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

87829fd

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

4e66dd9

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

277506e

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

64aca92

Signed-off-by: Jovan Cvetkovic <[email protected]>

Code review opensearch-project#573

f989735

Signed-off-by: Jovan Cvetkovic <[email protected]>

lezzago reviewed Jul 11, 2023

View reviewed changes

public/pages/CreateTrigger/containers/CreateTrigger/utils/constants.js Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

public/pages/Dashboard/containers/Dashboard.js Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

lezzago reviewed Jul 11, 2023

View reviewed changes

server/services/AlertService.js Outdated Show resolved Hide resolved

addressed PR comments; changed description texts

07e9116

Signed-off-by: Amardeepsingh Siglani <[email protected]>

amsiglan added 2 commits July 11, 2023 15:27

fixed cypress tests

a492813

Signed-off-by: Amardeepsingh Siglani <[email protected]>

updated cypress tests

2c363ec

Signed-off-by: Amardeepsingh Siglani <[email protected]>

amsiglan added backport 2.x backport 2.9 labels Jul 11, 2023

amsiglan changed the title ~~Composite monitor list and details~~ Composite monitors Jul 11, 2023

lezzago reviewed Jul 11, 2023

View reviewed changes

cypress/integration/composite_level_monitor_spec.js Outdated Show resolved Hide resolved

removed commented code

e2204d5

Signed-off-by: Amardeepsingh Siglani <[email protected]>

lezzago approved these changes Jul 11, 2023

View reviewed changes

AWSHurneyt reviewed Jul 11, 2023

View reviewed changes

AWSHurneyt approved these changes Jul 12, 2023

View reviewed changes

amsiglan merged commit bb2ed74 into opensearch-project:main Jul 12, 2023

opensearch-trigger-bot bot mentioned this pull request Jul 12, 2023

[Backport 2.x] Composite monitors #614

Merged

opensearch-trigger-bot bot mentioned this pull request Jul 12, 2023

[Backport 2.9] Composite monitors #615

Merged

lezzago mentioned this pull request Jul 15, 2023

Fix monitor parse and alerts table #645

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Composite monitors #611

Composite monitors #611

amsiglan commented Jul 11, 2023

lezzago commented Jul 11, 2023

codecov bot commented Jul 11, 2023 •

edited

Loading

AWSHurneyt left a comment

AWSHurneyt Jul 11, 2023

amsiglan Jul 11, 2023

AWSHurneyt Jul 11, 2023

AWSHurneyt Jul 11, 2023

amsiglan Jul 11, 2023

AWSHurneyt Jul 11, 2023

AWSHurneyt Jul 11, 2023

AWSHurneyt Jul 11, 2023

AWSHurneyt Jul 11, 2023

AWSHurneyt Jul 11, 2023

amsiglan commented Jul 12, 2023

Composite monitors #611

Composite monitors #611

Conversation

amsiglan commented Jul 11, 2023

Description

Issues Resolved

Check List

lezzago commented Jul 11, 2023

codecov bot commented Jul 11, 2023 • edited Loading

Codecov Report

AWSHurneyt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amsiglan commented Jul 12, 2023

codecov bot commented Jul 11, 2023 •

edited

Loading