Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
… API. Signed-off-by: AWSHurneyt <[email protected]>
…was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
…usted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]>
|
Will be revising this PR with snapshot updates shortly. |
Signed-off-by: AWSHurneyt <[email protected]>
|
Snapshots have been updated, and unit test workflow is now passing. |
lezzago
approved these changes
Apr 21, 2022
praveensameneni
approved these changes
Apr 21, 2022
AWSHurneyt
added a commit
that referenced
this pull request
Apr 21, 2022
* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (#197) Signed-off-by: AWSHurneyt <[email protected]> * Fixed bugs associated with alerts table, and addressed UX review feedback. (#222) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (#223) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshot. Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Jun 10, 2022
* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (opensearch-project#197) Signed-off-by: AWSHurneyt <[email protected]> * Fixed bugs associated with alerts table, and addressed UX review feedback. (opensearch-project#222) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (opensearch-project#223) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshot. Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.