Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. #197

AWSHurneyt · 2022-03-18T00:40:35Z

Description

Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands.
Added cypress tests to verify fix.

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ng when editing a monitor that was created through backend commands. Added cypress tests to verify fix. Signed-off-by: AWSHurneyt <[email protected]>

codecov-commenter · 2022-03-18T00:53:19Z

Codecov Report

Merging #197 (f05f9f2) into main (682f91c) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   53.20%   53.26%   +0.06%     
==========================================
  Files         209      209              
  Lines        5250     5262      +12     
  Branches      710      712       +2     
==========================================
+ Hits         2793     2803      +10     
- Misses       2455     2457       +2     
  Partials        2        2

Impacted Files	Coverage Δ
...eMonitor/containers/CreateMonitor/CreateMonitor.js	`60.83% <0.00%> (+2.50%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682f91c...f05f9f2. Read the comment docs.

AWSHurneyt · 2022-03-18T16:34:43Z

The cypress tests seem to currently be failing at the moment because they run using the OpenSearch-Dashboards 1.x branch, whereas alerting-dashboards-plugin main branch is configured as version 1.3. All cypress tests are passing locally.

* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (#197) Signed-off-by: AWSHurneyt <[email protected]> * Fixed bugs associated with alerts table, and addressed UX review feedback. (#222) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (#223) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshot. Signed-off-by: AWSHurneyt <[email protected]>

* Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. Added cypress tests to verify fix. (opensearch-project#197) Signed-off-by: AWSHurneyt <[email protected]> * Fixed bugs associated with alerts table, and addressed UX review feedback. (opensearch-project#222) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. (opensearch-project#223) * Removed unsupported prop from EuiGrid. Signed-off-by: AWSHurneyt <[email protected]> * Increased limit of doc level trigger conditions. Signed-off-by: AWSHurneyt <[email protected]> * Refactored empty dashboard button based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored query performance text based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getAlerts API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored logic to apply default sortField value for the getFindings API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alerts table to display finding doc IDs. Fixed a bug that was preventing the alerts flyout table from refreshing after acknowledging alerts. Removed edit monitor button from alerts table on monitor details page. Fixed a bug that was causing the monitor create/update page to crash when changing from extraction editor to visual editor. Refactored position of finding flyout. Fixed a bug that was preventing sorting and pagination of the findings table. Repurposed QueryPopover to FindingsPopover, and added support for displaying doc IDs using the popover. Removed parentheses from the trigger condition sent to backend. Added validation for queries defined using the visual editor. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots, and implemented fix for a unit test. Signed-off-by: AWSHurneyt <[email protected]> * Added document column to alerts dashboard for doc level monitors. Adjusted alerts dashboard configuration to remove unused alert states for doc level monitors. Refactored style of alerts flyout based on UX feedback. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshot. Signed-off-by: AWSHurneyt <[email protected]>

Fixed a bug that was preventing the configured schedule from displayi…

2a973ce

…ng when editing a monitor that was created through backend commands. Added cypress tests to verify fix. Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt requested review from qreshi, annie3431, getsaurabh02 and lezzago March 18, 2022 16:33

AWSHurneyt marked this pull request as ready for review March 30, 2022 17:07

AWSHurneyt requested a review from a team March 30, 2022 17:07

lezzago previously approved these changes Apr 3, 2022

View reviewed changes

Merge branch 'opensearch-project:main' into main-issue32

a9cf77b

praveensameneni approved these changes Apr 19, 2022

View reviewed changes

praveensameneni previously approved these changes Apr 19, 2022

View reviewed changes

Merge branch 'main' into main-issue32

f05f9f2

AWSHurneyt dismissed stale reviews from praveensameneni and lezzago via f05f9f2 April 21, 2022 01:14

lezzago approved these changes Apr 21, 2022

View reviewed changes

getsaurabh02 approved these changes Apr 21, 2022

View reviewed changes

AWSHurneyt merged commit f75b2f5 into opensearch-project:main Apr 21, 2022

AWSHurneyt mentioned this pull request Jul 12, 2022

[BUG] OpenSearch Dashboard Alerting Monitor Interval #229

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. #197

Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. #197

AWSHurneyt commented Mar 18, 2022

codecov-commenter commented Mar 18, 2022 •

edited

Loading

AWSHurneyt commented Mar 18, 2022

Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. #197

Fixed a bug that was preventing the configured schedule from displaying when editing a monitor that was created through backend commands. #197

Conversation

AWSHurneyt commented Mar 18, 2022

Description

Issues Resolved

Check List

codecov-commenter commented Mar 18, 2022 • edited Loading

Codecov Report

AWSHurneyt commented Mar 18, 2022

codecov-commenter commented Mar 18, 2022 •

edited

Loading