-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing javadoc error #9976
Fixing javadoc error #9976
Conversation
fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]>
Compatibility status:Checks if related components are compatible with change 5fc2973 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
@ker2x there javadoc issues:
|
Thank you, apologies for messing it up |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Laurent Laborde <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Laurent Laborde <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Thanks @kotwanikunal , all kinds of issues, including
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
libs/core/src/main/java/org/opensearch/core/common/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
libs/core/src/main/java/org/opensearch/core/common/breaker/NoopCircuitBreaker.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]>
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * removing unsupported @ImplNote Signed-off-by: Laurent Laborde <[email protected]> * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update CollectionUtils.java Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc warnings Signed-off-by: Laurent Laborde <[email protected]> * remove useless p tag Signed-off-by: Laurent Laborde <[email protected]> * removing a p tag Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * proper capitalization Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 71f6136) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal * removing unsupported @ImplNote * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update CollectionUtils.java * fixing javadoc warnings * remove useless p tag * removing a p tag * proper capitalization --------- (cherry picked from commit 71f6136) Signed-off-by: Laurent Laborde <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * removing unsupported @ImplNote Signed-off-by: Laurent Laborde <[email protected]> * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update CollectionUtils.java Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc warnings Signed-off-by: Laurent Laborde <[email protected]> * remove useless p tag Signed-off-by: Laurent Laborde <[email protected]> * removing a p tag Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * proper capitalization Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * removing unsupported @ImplNote Signed-off-by: Laurent Laborde <[email protected]> * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update CollectionUtils.java Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc warnings Signed-off-by: Laurent Laborde <[email protected]> * remove useless p tag Signed-off-by: Laurent Laborde <[email protected]> * removing a p tag Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * proper capitalization Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * removing unsupported @ImplNote Signed-off-by: Laurent Laborde <[email protected]> * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update CollectionUtils.java Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc warnings Signed-off-by: Laurent Laborde <[email protected]> * remove useless p tag Signed-off-by: Laurent Laborde <[email protected]> * removing a p tag Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * proper capitalization Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
* Fixing javadoc error fixing javadoc error and warning javadoc for org.opensearch.core.indices.breaker javadoc for org.opensearch.core.index.shard.ShardId javadoc for org.opensearch.core.index.Index fixing a mishap in formatting rule fixing javadoc of org.opensearch.cli.Terminal Signed-off-by: Laurent Laborde <[email protected]> * removing unsupported @ImplNote Signed-off-by: Laurent Laborde <[email protected]> * Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Apply suggestions from code review Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * Update CollectionUtils.java Signed-off-by: Laurent Laborde <[email protected]> * fixing javadoc warnings Signed-off-by: Laurent Laborde <[email protected]> * remove useless p tag Signed-off-by: Laurent Laborde <[email protected]> * removing a p tag Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> * proper capitalization Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Laurent Laborde <[email protected]> --------- Signed-off-by: Laurent Laborde <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Friendly greetings !
i wrote more javadoc and fixed some mistake from the previous PR.
I ran gradle precommit and check
There are some errors unrelated to my commits
meta ticket #221
PS : signoff should be ok this time
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.