Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fixing javadoc error #10049

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[Backport 2.x] Fixing javadoc error #10049

merged 1 commit into from
Sep 14, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 71f6136 from #9976.

@github-actions @reta
Fixing javadoc error (#9976)
cecaa94 
* Fixing javadoc error
fixing javadoc error and warning
javadoc for org.opensearch.core.indices.breaker
javadoc for org.opensearch.core.index.shard.ShardId
javadoc for org.opensearch.core.index.Index
fixing a mishap in formatting rule
fixing javadoc of org.opensearch.cli.Terminal

Signed-off-by: Laurent Laborde <[email protected]>

* removing unsupported @ImplNote

Signed-off-by: Laurent Laborde <[email protected]>

* Update libs/common/src/main/java/org/opensearch/common/collect/Iterators.java

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Update libs/compress/src/main/java/org/opensearch/compress/ZstdCompressor.java

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* Update CollectionUtils.java

Signed-off-by: Laurent Laborde <[email protected]>

* fixing javadoc warnings

Signed-off-by: Laurent Laborde <[email protected]>

* remove useless p tag

Signed-off-by: Laurent Laborde <[email protected]>

* removing a p tag

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

* proper capitalization

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Laurent Laborde <[email protected]>

---------

Signed-off-by: Laurent Laborde <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 71f6136)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cecaa94

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #10049 (cecaa94) into 2.x (4c9042f) will decrease coverage by 0.15%.
Report is 1 commits behind head on 2.x.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                2.x   #10049      +/-   ##
============================================
- Coverage     70.89%   70.75%   -0.15%     
+ Complexity    58291    58186     -105     
============================================
  Files          4810     4810              
  Lines        275140   275140              
  Branches      40440    40440              
============================================
- Hits         195074   194663     -411     
- Misses        63389    63820     +431     
+ Partials      16677    16657      -20
Files Changed Coverage Δ
.../java/org/opensearch/common/collect/Iterators.java 75.00% <ø> (ø)
...n/java/org/opensearch/compress/ZstdCompressor.java 52.94% <ø> (-17.65%) ⬇️
...opensearch/core/common/breaker/CircuitBreaker.java 75.00% <ø> (ø)
.../core/common/breaker/CircuitBreakingException.java 89.28% <ø> (ø)
...search/core/common/breaker/NoopCircuitBreaker.java 61.53% <0.00%> (ø)
...earch/core/common/logging/LoggerMessageFormat.java 20.14% <ø> (ø)
...search/core/common/transport/TransportAddress.java 79.48% <ø> (ø)
.../org/opensearch/core/common/unit/ByteSizeUnit.java 80.00% <ø> (ø)
...g/opensearch/core/common/util/CollectionUtils.java 77.06% <ø> (ø)
...src/main/java/org/opensearch/core/index/Index.java 100.00% <ø> (ø)
... and 6 more

... and 457 files with indirect coverage changes

@reta reta merged commit 4563ebc into 2.x Sep 14, 2023
39 of 66 checks passed
@github-actions github-actions bot deleted the backport/backport-9976-to-2.x branch September 14, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poojita-Raj Poojita-Raj Poojita-Raj approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @Poojita-Raj