Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm architecture translation issue (#809) #917

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

peternied
Copy link
Member

Backporting this change to the release branch, original PR.


Found when attempting to build on an arm64 machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the == sign.

unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64]

Signed-off-by: Peter Nied [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Found when attempting to build on an `arm64` machine when I recieved an error message below.  Root cause is that string equality in java cannot be done with the `==` sign.

```
unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64]
```

Signed-off-by: Peter Nied <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a8c02fc

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed a8c02fc

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success a8c02fc

@nknize
Copy link
Collaborator

nknize commented Jul 1, 2021

start gradle check

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize added backport PRs or issues specific to backporting features or enhancments bug Something isn't working Build Libraries & Interfaces v1.0.0 Version 1.0.0 labels Jul 1, 2021
@nknize
Copy link
Collaborator

nknize commented Jul 1, 2021

Hey @peternied do we have an open issue to track Arm64 support? I couldn't find one so I'm afraid these kinds of issues aren't going to be fully captured for the GA release.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success a8c02fc
Log 289

Reports 289

@peternied
Copy link
Member Author

Hey @peternied do we have an open issue to track Arm64 support? I couldn't find one so I'm afraid these kinds of issues aren't going to be fully captured for the GA release.

@nknize I created issue #925 - we can use that issue to drive any additional work.

@peternied peternied merged commit f1fa940 into opensearch-project:1.0 Jul 2, 2021
@nknize
Copy link
Collaborator

nknize commented Jul 2, 2021

Thanks for creating the issue. I made a mistake and didn't pay attention that this PR was against 1.0. We should be opening the PRs against the 1.x branch and then we'll cherry-pick to 1.0. /cc @adnapibar

@peternied peternied deleted the backport-arm-build-fix branch July 2, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments bug Something isn't working Build Libraries & Interfaces v1.0.0 Version 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants