-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arm architecture translation issue (#809) #917
Fix arm architecture translation issue (#809) #917
Conversation
Found when attempting to build on an `arm64` machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the `==` sign. ``` unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64] ``` Signed-off-by: Peter Nied <[email protected]>
✅ Gradle Wrapper Validation success a8c02fc |
✅ DCO Check Passed a8c02fc |
✅ Gradle Precommit success a8c02fc |
start gradle check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @peternied do we have an open issue to track Arm64 support? I couldn't find one so I'm afraid these kinds of issues aren't going to be fully captured for the GA release. |
@nknize I created issue #925 - we can use that issue to drive any additional work. |
Thanks for creating the issue. I made a mistake and didn't pay attention that this PR was against 1.0. We should be opening the PRs against the 1.x branch and then we'll cherry-pick to 1.0. /cc @adnapibar |
Backporting this change to the release branch, original PR.
Found when attempting to build on an
arm64
machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the==
sign.Signed-off-by: Peter Nied [email protected]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.