Fix arm architecture translation issue #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found when attempting to build on an `arm64` machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the `==` sign. ``` unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64] ``` Signed-off-by: Peter Nied <[email protected]>
|
✅ Gradle Wrapper Validation success 6ac7255 |
|
✅ DCO Check Passed 6ac7255 |
|
✅ Gradle Precommit success 6ac7255 |
|
start gradle check |
saratvemulapalli
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Thanks Peter.
I just learned the difference between == and .equals() :)
Ref: https://www.tutorialspoint.com/differences-between-and-equals-method-in-java
saratvemulapalli
added
the
pending backport
peternied
added a commit
to peternied/OpenSearch-1
that referenced
this pull request
Jul 1, 2021
Found when attempting to build on an `arm64` machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the `==` sign. ``` unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64] ``` Signed-off-by: Peter Nied <[email protected]>
This was referenced Jul 1, 2021
peternied
added a commit
that referenced
this pull request
Jul 2, 2021
Found when attempting to build on an `arm64` machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the `==` sign. ``` unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64] ``` Signed-off-by: Peter Nied <[email protected]>
tlfeng
added
bug
1 task
nknize
pushed a commit
that referenced
this pull request
Jul 2, 2021
Found when attempting to build on an `arm64` machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the `==` sign. ``` unknown architecture [arm64] for jdk [provisioned_runtime], must be one of [aarch64, x64] ``` Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Peter Nied <[email protected]>
dblock
removed
the
pending backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found when attempting to build on an
arm64machine when I recieved an error message below. Root cause is that string equality in java cannot be done with the==sign.Issues Resolved
Fixes arm64 build issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.