Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With only GlobalAggregation in request causes unnecessary wrapping with MultiCollector #8129

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented Jun 17, 2023

Description

Backport of #8125

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #8129 (9916712) into 2.x (4a090af) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                2.x    #8129      +/-   ##
============================================
- Coverage     70.71%   70.71%   -0.01%     
+ Complexity    56848    56841       -7     
============================================
  Files          4703     4703              
  Lines        269056   269056              
  Branches      39770    39770              
============================================
- Hits         190263   190255       -8     
- Misses        62452    62507      +55     
+ Partials      16341    16294      -47     
Impacted Files Coverage Δ
...n/java/org/opensearch/search/query/QueryPhase.java 78.80% <88.88%> (ø)

... and 466 files with indirect coverage changes

@reta reta merged commit 26b7203 into opensearch-project:2.x Jun 17, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants