-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With only GlobalAggregation in request causes unnecessary wrapping with MultiCollector #8125
Conversation
…th MultiCollector Signed-off-by: Sorabh Hamirwasia <[email protected]>
@reta Tagging you for the review |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8125 +/- ##
============================================
- Coverage 70.98% 70.92% -0.07%
+ Complexity 56714 56612 -102
============================================
Files 4722 4722
Lines 267608 267608
Branches 39216 39216
============================================
- Hits 189962 189792 -170
- Misses 61589 61789 +200
+ Partials 16057 16027 -30
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8125-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 90678c2d76ed1c31aebc85a23fe5be12f6e81417
# Push it to GitHub
git push --set-upstream origin backport/backport-8125-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
sorry, @sohami, |
Will manually backport the changes |
…th MultiCollector (opensearch-project#8125) Signed-off-by: Sorabh Hamirwasia <[email protected]>
…th MultiCollector (#8125) (#8129) Signed-off-by: Sorabh Hamirwasia <[email protected]>
…th MultiCollector (opensearch-project#8125) (opensearch-project#8129) Signed-off-by: Sorabh Hamirwasia <[email protected]>
…th MultiCollector (opensearch-project#8125) Signed-off-by: Sorabh Hamirwasia <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
…th MultiCollector (opensearch-project#8125) Signed-off-by: Sorabh Hamirwasia <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Avoid adding redundant multi collector wrapper when only global agg is present in the search request
Related Issues
Resolves #8097
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.