Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Align range and default value for deletes_pct_allowed in merge policy… #8002

Merged

Conversation

nkumar04
Copy link
Contributor

… (#7730)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (#7360)

Signed-off-by: Nikhil Kumar [email protected]
Co-authored-by: Nikhil Kumar [email protected]
(cherry picked from commit 9b2b3c9)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…opensearch-project#7730)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <[email protected]>
Co-authored-by: Nikhil Kumar <[email protected]>
(cherry picked from commit 9b2b3c9)
@nkumar04 nkumar04 changed the title Align range and default value for deletes_pct_allowed in merge policy… [Backport 2.x] Align range and default value for deletes_pct_allowed in merge policy… Jun 12, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #8002 (0277bbf) into 2.x (5953580) will increase coverage by 0.08%.
The diff coverage is 80.26%.

@@             Coverage Diff              @@
##                2.x    #8002      +/-   ##
============================================
+ Coverage     70.58%   70.66%   +0.08%     
- Complexity    56561    56608      +47     
============================================
  Files          4682     4683       +1     
  Lines        268195   268241      +46     
  Branches      39673    39675       +2     
============================================
+ Hits         189295   189556     +261     
+ Misses        62647    62346     -301     
- Partials      16253    16339      +86     
Impacted Files Coverage Δ
...n/java/org/opensearch/index/MergePolicyConfig.java 74.66% <ø> (ø)
...ch/indices/recovery/PeerRecoveryTargetService.java 53.92% <0.00%> (ø)
...ces/replication/PrimaryShardReplicationSource.java 96.00% <ø> (ø)
.../indices/replication/SegmentReplicationSource.java 100.00% <ø> (ø)
...s/replication/SegmentReplicationSourceFactory.java 38.46% <0.00%> (-7.00%) ⬇️
.../indices/replication/SegmentReplicationTarget.java 86.44% <16.66%> (-3.83%) ⬇️
...ices/replication/RemoteStoreReplicationSource.java 93.54% <93.54%> (ø)
...in/java/org/opensearch/index/shard/IndexShard.java 70.65% <94.44%> (+1.27%) ⬆️
...va/org/opensearch/index/engine/InternalEngine.java 74.56% <100.00%> (-0.26%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 85.05% <100.00%> (ø)
... and 4 more

... and 476 files with indirect coverage changes

@shwetathareja shwetathareja merged commit 096226d into opensearch-project:2.x Jun 12, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…opensearch-project#7730) (opensearch-project#8002)

Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360)

Signed-off-by: Nikhil Kumar <[email protected]>
Co-authored-by: Nikhil Kumar <[email protected]>
(cherry picked from commit 9b2b3c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants