-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align range and default value for deletes_pct_allowed in merge policy #7730
Merged
shwetathareja
merged 1 commit into
opensearch-project:main
from
nkumar04:7360_merge_policy_tuning_for_del_pct
Jun 12, 2023
Merged
Align range and default value for deletes_pct_allowed in merge policy #7730
shwetathareja
merged 1 commit into
opensearch-project:main
from
nkumar04:7360_merge_policy_tuning_for_del_pct
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkumar04
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
May 24, 2023 14:16
nkumar04
force-pushed
the
7360_merge_policy_tuning_for_del_pct
branch
from
May 24, 2023 14:23
bcf41b0
to
ecb5d6c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7730 +/- ##
============================================
- Coverage 70.88% 70.85% -0.04%
+ Complexity 56352 56339 -13
============================================
Files 4700 4700
Lines 266549 266549
Branches 39099 39099
============================================
- Hits 188937 188856 -81
- Misses 61632 61723 +91
+ Partials 15980 15970 -10
|
Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360) Signed-off-by: Nikhil Kumar <[email protected]>
nkumar04
force-pushed
the
7360_merge_policy_tuning_for_del_pct
branch
from
June 7, 2023 04:44
ecb5d6c
to
29c018e
Compare
Gradle Check (Jenkins) Run Completed with:
|
mgodwan
reviewed
Jun 9, 2023
shwetathareja
approved these changes
Jun 9, 2023
reta
approved these changes
Jun 9, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7730-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b2b3c94728bc7f5f3771b440245a55341940a38
# Push it to GitHub
git push --set-upstream origin backport/backport-7730-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
nkumar04
added a commit
to nkumar04/OpenSearch
that referenced
this pull request
Jun 12, 2023
…opensearch-project#7730) Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360) Signed-off-by: Nikhil Kumar <[email protected]> Co-authored-by: Nikhil Kumar <[email protected]> (cherry picked from commit 9b2b3c9)
6 tasks
shwetathareja
pushed a commit
that referenced
this pull request
Jun 12, 2023
…#7730) (#8002) Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (#7360) Signed-off-by: Nikhil Kumar <[email protected]> Co-authored-by: Nikhil Kumar <[email protected]> (cherry picked from commit 9b2b3c9)
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…opensearch-project#7730) (opensearch-project#8002) Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360) Signed-off-by: Nikhil Kumar <[email protected]> Co-authored-by: Nikhil Kumar <[email protected]> (cherry picked from commit 9b2b3c9)
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…opensearch-project#7730) Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360) Signed-off-by: Nikhil Kumar <[email protected]> Co-authored-by: Nikhil Kumar <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…opensearch-project#7730) Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (opensearch-project#7360) Signed-off-by: Nikhil Kumar <[email protected]> Co-authored-by: Nikhil Kumar <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the range and default value for deletes_pct_allowed in merge policy for more control and optimal disk usage (#7360)
Description
This change is to align the default value of deletesPctAllowed in merge policy with Lucene. This change will help in optimal usage of disk and reduce the deleted docs in an index. Search performance would also be better if there are less deleted docs in an index.
Related Issues
Resolves #7360
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.