[Backport 2.x] Remove error path for ancient compression detection #7939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
dblock
approved these changes
Jun 6, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7939 +/- ##
============================================
- Coverage 70.50% 70.44% -0.07%
+ Complexity 56478 56442 -36
============================================
Files 4673 4673
Lines 267923 267919 -4
Branches 39647 39646 -1
============================================
- Hits 188909 188738 -171
- Misses 62693 62891 +198
+ Partials 16321 16290 -31
|
kotwanikunal
approved these changes
Jun 6, 2023
Gradle Check (Jenkins) Run Completed with:
|
The error message generated by this code path refers to Elasticsearch version 2.0.0.beta1, which is likely to cause confusion with the OpenSearch 2.x line if it were ever to be encountered. The ES2 version is so old that I don't think we need any special handling here and can just fall back to the default "not xcontent" error message. Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 4592d7c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
force-pushed
the
backport/backport-7932-to-2.x
branch
from
ce1ffeb to
416d261
Compare
Gradle Check (Jenkins) Run Completed with:
|
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ct#7932) (opensearch-project#7939) The error message generated by this code path refers to Elasticsearch version 2.0.0.beta1, which is likely to cause confusion with the OpenSearch 2.x line if it were ever to be encountered. The ES2 version is so old that I don't think we need any special handling here and can just fall back to the default "not xcontent" error message. (cherry picked from commit 4592d7c) Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4592d7c from #7932.