Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error path for ancient compression detection #7932

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Remove error path for ancient compression detection #7932

merged 1 commit into from
Jun 6, 2023

Conversation

andrross
Copy link
Member

@andrross andrross commented Jun 6, 2023

The error message generated by this code path refers to Elasticsearch version 2.0.0.beta1, which is likely to cause confusion with the OpenSearch 2.x line if it were ever to be encountered. The ES2 version is so old that I don't think we need any special handling here and can just fall back to the default "not xcontent" error message.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross
Remove error path for ancient compression detection
d75ba0e 
The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross added backport 2.x Backport to 2.x branch skip-changelog labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #7932 (d75ba0e) into main (d55813e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #7932      +/-   ##
============================================
- Coverage     70.87%   70.79%   -0.09%     
+ Complexity    56326    56270      -56     
============================================
  Files          4691     4691              
  Lines        266388   266384       -4     
  Branches      39090    39089       -1     
============================================
- Hits         188813   188586     -227     
- Misses        61566    61873     +307     
+ Partials      16009    15925      -84
Impacted Files Coverage Δ
.../opensearch/common/compress/CompressorFactory.java 66.66% <100.00%> (+14.66%) ⬆️

... and 495 files with indirect coverage changes

dblock
dblock approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code path tested at all? :)

@dblock dblock merged commit 4592d7c into opensearch-project:main Jun 6, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@github-actions
Remove error path for ancient compression detection (#7932)
ce1ffeb 
The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 4592d7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross deleted the compressor-factory-cleanup branch June 6, 2023 19:55
andrross pushed a commit that referenced this pull request Jun 6, 2023
@github-actions @andrross
Remove error path for ancient compression detection (#7932)
416d261 
The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 4592d7c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross
Copy link
Member Author

andrross commented Jun 7, 2023 •
edited
Loading

Is this code path tested at all? :)

@dblock It appears not! I didn't find any unit tests and was actually curious whether anything in gradle check would fail. Interestingly, codecov claims that this change "decreases coverage by 0.09%" which is odd given that it just removes untested code. I'm still trying to figure out how that is possible...

andrross pushed a commit that referenced this pull request Jun 7, 2023
@opensearch-trigger-bot @github-actions
Remove error path for ancient compression detection (#7932) (#7939)
55af919 
The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.


(cherry picked from commit 4592d7c)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dblock
Copy link
Member

dblock commented Jun 7, 2023

@andrross it's written in JavaScript? ;)

sandeshkr419 pushed a commit to sandeshkr419/OpenSearch that referenced this pull request Jun 8, 2023
@andrross @sandeshkr419
Remove error path for ancient compression detection (opensearch-proje…
9cf4d71 
…ct#7932)

The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.

Signed-off-by: Andrew Ross <[email protected]>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
@opensearch-trigger-bot @github-actions @gaiksaya
Remove error path for ancient compression detection (opensearch-proje…
cc535b0 
…ct#7932) (opensearch-project#7939)

The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.


(cherry picked from commit 4592d7c)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@andrross @shiv0408
Remove error path for ancient compression detection (opensearch-proje…
19a712a 
…ct#7932)

The error message generated by this code path refers to Elasticsearch
version 2.0.0.beta1, which is likely to cause confusion with the
OpenSearch 2.x line if it were ever to be encountered. The ES2 version
is so old that I don't think we need any special handling here and can
just fall back to the default "not xcontent" error message.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@dblock dblock dblock approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrross @dblock @reta @kotwanikunal