Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add ZSTD compression for snapshotting (#2996) #7906

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

willyborankin
Copy link
Contributor

Backport 4df347c from #2996.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #7906 (2c66e9e) into 2.x (32ca5f9) will decrease coverage by 0.10%.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##                2.x    #7906      +/-   ##
============================================
- Coverage     70.57%   70.47%   -0.10%     
+ Complexity    56411    56367      -44     
============================================
  Files          4666     4669       +3     
  Lines        267727   267760      +33     
  Branches      39639    39642       +3     
============================================
- Hits         188944   188708     -236     
- Misses        62517    62744     +227     
- Partials      16266    16308      +42     
Impacted Files Coverage Δ
...repositories/gcs/GoogleCloudStorageRepository.java 0.00% <0.00%> (ø)
...a/org/opensearch/repositories/s3/S3Repository.java 61.36% <ø> (-0.44%) ⬇️
...a/org/opensearch/repositories/fs/FsRepository.java 70.00% <ø> (-0.74%) ⬇️
...org/opensearch/common/compress/NoneCompressor.java 28.57% <28.57%> (ø)
...org/opensearch/common/compress/ZstdCompressor.java 52.94% <52.94%> (ø)
.../opensearch/common/compress/CompressorFactory.java 52.00% <57.14%> (-0.64%) ⬇️
...ch/repositories/blobstore/BlobStoreRepository.java 62.31% <63.15%> (+0.15%) ⬆️
.../opensearch/common/compress/DeflateCompressor.java 82.02% <83.33%> (+0.38%) ⬆️
...opensearch/repositories/azure/AzureRepository.java 66.66% <100.00%> (-1.52%) ⬇️
...g/opensearch/repositories/hdfs/HdfsRepository.java 61.90% <100.00%> (ø)
... and 2 more

... and 449 files with indirect coverage changes

Changes:

- Added ZSTD compressor for snapshotting
- 2 JSON repository settings:
  - readonly
  - compression
were moved into the BlobStoreRepository class
and removed from other repos classes where they
were used.

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin force-pushed the backport-2996-to-2.x branch from 163df70 to 2c66e9e Compare June 4, 2023 09:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@reta reta merged commit fb74a73 into opensearch-project:2.x Jun 5, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…search-project#7906)

Changes:

- Added ZSTD compressor for snapshotting
- 2 JSON repository settings:
  - readonly
  - compression
were moved into the BlobStoreRepository class
and removed from other repos classes where they
were used.

Signed-off-by: Andrey Pleskach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants