-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Remove codec name string match check for checkpoints #7741
[Segment Replication] Remove codec name string match check for checkpoints #7741
Conversation
Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Poojita Raj <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7741 +/- ##
============================================
+ Coverage 70.63% 70.94% +0.30%
- Complexity 56099 56248 +149
============================================
Files 4680 4680
Lines 266083 266075 -8
Branches 39074 39072 -2
============================================
+ Hits 187955 188773 +818
+ Misses 62187 61283 -904
- Partials 15941 16019 +78
|
Gradle Check (Jenkins) Run Completed with:
|
…oints (#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]> (cherry picked from commit 89edd55) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oints (opensearch-project#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]>
…oints (#7741) (#7744) * Remove codec name string match check for checkpoints * changelog added --------- (cherry picked from commit 89edd55) Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Suraj Singh <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Suraj Singh <[email protected]>
@Poojita-Raj @dreamer-89 I think this should be backported to 2.7 as well so we can support non default codecs with 2.7 line. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-7741-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89edd552313d1a32e6d97c33bb7d2d57e6c7670c
# Push it to GitHub
git push --set-upstream origin backport/backport-7741-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.7 Then, create a pull request where the |
…oints (opensearch-project#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]>
…oints (#7741) (#7786) * Remove codec name string match check for checkpoints * changelog added --------- Signed-off-by: Poojita Raj <[email protected]> Co-authored-by: Poojita Raj <[email protected]>
…oints (opensearch-project#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]>
…oints (opensearch-project#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]>
…r checkpoints (opensearch-project#7741)" This reverts commit 89edd55.
…oints (opensearch-project#7741) (opensearch-project#7744) * Remove codec name string match check for checkpoints * changelog added --------- (cherry picked from commit 89edd55) Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Suraj Singh <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Suraj Singh <[email protected]>
…oints (opensearch-project#7741) * Remove codec name string match check for checkpoints Signed-off-by: Poojita Raj <[email protected]> * changelog added Signed-off-by: Poojita Raj <[email protected]> --------- Signed-off-by: Poojita Raj <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Moving forward, we want to perform version checks to ascertain if incoming checkpoints can be processed rather than relying on string matching of codec names. By knowing which version we are on, we will also know which lucene codecs it supports.
Related Issues
Resolves #7742
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.