Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Remove codec name string match check for checkpoints #7741

Merged
merged 2 commits into from
May 24, 2023

Conversation

Poojita-Raj
Copy link
Contributor

@Poojita-Raj Poojita-Raj commented May 24, 2023

Description

Moving forward, we want to perform version checks to ascertain if incoming checkpoints can be processed rather than relying on string matching of codec names. By knowing which version we are on, we will also know which lucene codecs it supports.

Related Issues

Resolves #7742

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Poojita Raj <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #7741 (2008a1d) into main (70b109d) will increase coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 2008a1d differs from pull request most recent head 59f8cb6. Consider uploading reports for the commit 59f8cb6 to get more accurate results

@@             Coverage Diff              @@
##               main    #7741      +/-   ##
============================================
+ Coverage     70.63%   70.94%   +0.30%     
- Complexity    56099    56248     +149     
============================================
  Files          4680     4680              
  Lines        266083   266075       -8     
  Branches      39074    39072       -2     
============================================
+ Hits         187955   188773     +818     
+ Misses        62187    61283     -904     
- Partials      15941    16019      +78     
Impacted Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 70.13% <ø> (-0.13%) ⬇️
...ndices/replication/OngoingSegmentReplications.java 92.77% <ø> (-0.34%) ⬇️

... and 456 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.blocks.SimpleBlocksIT.testAddBlockWhileDeletingIndices

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 24, 2023
…oints (#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 89edd55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit to dblock/OpenSearch that referenced this pull request May 25, 2023
…oints (opensearch-project#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
mch2 pushed a commit that referenced this pull request May 25, 2023
…oints (#7741) (#7744)

* Remove codec name string match check for checkpoints



* changelog added



---------


(cherry picked from commit 89edd55)

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Suraj Singh <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Suraj Singh <[email protected]>
@mch2
Copy link
Member

mch2 commented May 26, 2023

@Poojita-Raj @dreamer-89 I think this should be backported to 2.7 as well so we can support non default codecs with 2.7 line.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-7741-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89edd552313d1a32e6d97c33bb7d2d57e6c7670c
# Push it to GitHub
git push --set-upstream origin backport/backport-7741-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-7741-to-2.7.

dreamer-89 pushed a commit to dreamer-89/OpenSearch that referenced this pull request May 26, 2023
…oints (opensearch-project#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
dreamer-89 added a commit that referenced this pull request May 26, 2023
…oints (#7741) (#7786)

* Remove codec name string match check for checkpoints



* changelog added



---------

Signed-off-by: Poojita Raj <[email protected]>
Co-authored-by: Poojita Raj <[email protected]>
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
…oints (opensearch-project#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
…oints (opensearch-project#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Jun 2, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…oints (opensearch-project#7741) (opensearch-project#7744)

* Remove codec name string match check for checkpoints



* changelog added



---------


(cherry picked from commit 89edd55)

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Suraj Singh <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Suraj Singh <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…oints (opensearch-project#7741)

* Remove codec name string match check for checkpoints

Signed-off-by: Poojita Raj <[email protected]>

* changelog added

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Segment Replication] Remove codec name string match check for checkpoints
3 participants