Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Remove codec name string match check for checkpoints #7742

Closed
Poojita-Raj opened this issue May 24, 2023 · 0 comments · Fixed by #7741
Closed

[Segment Replication] Remove codec name string match check for checkpoints #7742

Poojita-Raj opened this issue May 24, 2023 · 0 comments · Fixed by #7741
Labels
bug Something isn't working untriaged

Comments

@Poojita-Raj
Copy link
Contributor

Describe the bug

The current codec name string matching check is not sustainable as we move forward with future releases. It doesn't allow for us to support mixed version clusters as it expects the same codec every time.

Additionally, this logic does not support custom codecs (eg: knn plugin uses its custom knn codec that wraps underlying lucene codec).

For a custom codec with the name "customLucene95Codec" and our default codec with name "Lucene95", even though the replica is able to read the custom codec since it uses the same underlying codec - it will not process the checkpoint since the names do not match.

Expected behavior
Moving forward, we want to perform version checks to ascertain if incoming checkpoints can be processed rather than relying on string matching of codec names. By knowing which version we are on, we will also know which lucene codecs it supports.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant