Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removed duplicated 'nodeId' in cache path #7059 #7086

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ed6141f from #7065.

* Removed duplicated 'nodeId' in cache path #7059

Signed-off-by: Andrew Ross <[email protected]>

* Update tests and restore logic for new path

Signed-off-by: Andrew Ross <[email protected]>

* Fix spotless errors

Signed-off-by: Andrew Ross <[email protected]>

* Fix additional tests

Signed-off-by: Andrew Ross <[email protected]>

* Fix integration test

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Jayesh Suthar <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit ed6141f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #7086 (2281a15) into 2.x (535cbac) will increase coverage by 0.12%.
The diff coverage is 85.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #7086      +/-   ##
============================================
+ Coverage     70.28%   70.41%   +0.12%     
- Complexity    59527    59596      +69     
============================================
  Files          4824     4824              
  Lines        286330   286320      -10     
  Branches      41626    41624       -2     
============================================
+ Hits         201250   201607     +357     
+ Misses        68279    67846     -433     
- Partials      16801    16867      +66     
Impacted Files Coverage Δ
.../main/java/org/opensearch/env/NodeEnvironment.java 76.80% <83.33%> (-1.26%) ⬇️
...index/store/remote/filecache/FileCacheCleaner.java 72.72% <100.00%> (-1.56%) ⬇️

... and 480 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@kotwanikunal kotwanikunal merged commit a699ad1 into 2.x Apr 11, 2023
@github-actions github-actions bot deleted the backport/backport-7065-to-2.x branch April 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants