Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated 'nodeId' in cache path #7059 #7065

Merged

Conversation

govegito
Copy link
Contributor

@govegito govegito commented Apr 9, 2023

Description

So in this issue, i removed the duplicate that was present in the cache path generated.

Issues Resolved

Closes #7059

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Gradle Check (Jenkins) Run Completed with:

@andrross andrross force-pushed the govegito/fixes-issue-#7059 branch from ef0a69e to 5e8c023 Compare April 10, 2023 20:17
@andrross andrross force-pushed the govegito/fixes-issue-#7059 branch from 5e8c023 to 14006da Compare April 10, 2023 20:22
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Andrew Ross <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

Thanks for your contribution @govegito! @andrross has helped resolve test failures and a linked use case for the same.
This LGTM!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross added the backport 2.x Backport to 2.x branch label Apr 10, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

@andrross

      src/internalClusterTest/java/org/opensearch/snapshots/SearchableSnapshotIT.java
1106 actionable tasks: 1105 executed, 1 from cache
          @@ -36,7 +36,6 @@
           import·org.opensearch.repositories.fs.FsRepository;
           
           import·java.io.IOException;
          -import·java.nio.file.DirectoryStream;
           import·java.nio.file.Files;
           import·java.nio.file.Path;
           import·java.util.List;
  Run './gradlew :server:spotlessApply' to fix these violations.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the govegito/fixes-issue-#7059 branch from d79304f to 3cc4bbb Compare April 10, 2023 23:52
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal kotwanikunal merged commit ed6141f into opensearch-project:main Apr 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2023
* Removed duplicated 'nodeId' in cache path #7059

Signed-off-by: Andrew Ross <[email protected]>

* Update tests and restore logic for new path

Signed-off-by: Andrew Ross <[email protected]>

* Fix spotless errors

Signed-off-by: Andrew Ross <[email protected]>

* Fix additional tests

Signed-off-by: Andrew Ross <[email protected]>

* Fix integration test

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Jayesh Suthar <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit ed6141f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 11, 2023
* Removed duplicated 'nodeId' in cache path #7059



* Update tests and restore logic for new path



* Fix spotless errors



* Fix additional tests



* Fix integration test



---------




(cherry picked from commit ed6141f)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jayesh Suthar <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023
…ensearch-project#7065)

* Removed duplicated 'nodeId' in cache path opensearch-project#7059

Signed-off-by: Andrew Ross <[email protected]>

* Update tests and restore logic for new path

Signed-off-by: Andrew Ross <[email protected]>

* Fix spotless errors

Signed-off-by: Andrew Ross <[email protected]>

* Fix additional tests

Signed-off-by: Andrew Ross <[email protected]>

* Fix integration test

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Jayesh Suthar <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Searchable Snapshot] Remove superfluous 'nodeId' in cache path
3 participants