-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicated 'nodeId' in cache path #7059 #7065
Merged
kotwanikunal
merged 5 commits into
opensearch-project:main
from
govegito:govegito/fixes-issue-#7059
Apr 11, 2023
Merged
Removed duplicated 'nodeId' in cache path #7059 #7065
kotwanikunal
merged 5 commits into
opensearch-project:main
from
govegito:govegito/fixes-issue-#7059
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govegito
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
April 9, 2023 05:35
Gradle Check (Jenkins) Run Completed with:
|
andrross
force-pushed
the
govegito/fixes-issue-#7059
branch
from
April 10, 2023 20:17
ef0a69e
to
5e8c023
Compare
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
govegito/fixes-issue-#7059
branch
from
April 10, 2023 20:22
5e8c023
to
14006da
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Andrew Ross <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
kotwanikunal
approved these changes
Apr 10, 2023
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Andrew Ross <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
govegito/fixes-issue-#7059
branch
from
April 10, 2023 23:52
d79304f
to
3cc4bbb
Compare
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Removed duplicated 'nodeId' in cache path #7059 Signed-off-by: Andrew Ross <[email protected]> * Update tests and restore logic for new path Signed-off-by: Andrew Ross <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> * Fix additional tests Signed-off-by: Andrew Ross <[email protected]> * Fix integration test Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Jayesh Suthar <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit ed6141f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Removed duplicated 'nodeId' in cache path #7059 * Update tests and restore logic for new path * Fix spotless errors * Fix additional tests * Fix integration test --------- (cherry picked from commit ed6141f) Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jayesh Suthar <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…ensearch-project#7065) * Removed duplicated 'nodeId' in cache path opensearch-project#7059 Signed-off-by: Andrew Ross <[email protected]> * Update tests and restore logic for new path Signed-off-by: Andrew Ross <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> * Fix additional tests Signed-off-by: Andrew Ross <[email protected]> * Fix integration test Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Jayesh Suthar <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So in this issue, i removed the duplicate that was present in the cache path generated.
Issues Resolved
Closes #7059
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.