Refactor buffer interval code for remote-backed indexes

[ashking94]

Signed-off-by: Ashish Singh [email protected]

Description

Fixes minor comment on variable naming - #5854 (comment)

Issues Resolved

Fixes minor comment on variable naming - #5854 (comment)

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/10145/
• CommitID: 6ecc2f8

[codecov-commenter]

Codecov Report

Merging #6063 (6ecc2f8) into main (cd860ec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6063      +/-   ##
============================================
+ Coverage     70.68%   70.70%   +0.02%     
+ Complexity    58714    58694      -20     
============================================
  Files          4775     4775              
  Lines        280993   280993              
  Branches      40590    40590              
============================================
+ Hits         198626   198687      +61     
+ Misses        66031    66012      -19     
+ Partials      16336    16294      -42     

Impacted Files	Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java	70.04% <ø> (-0.71%)	⬇️
...mmon/util/concurrent/BufferedAsyncIOProcessor.java	68.96% <100.00%> (ø)
...org/opensearch/test/engine/MockInternalEngine.java	0.00% <0.00%> (-73.92%)	⬇️
.../org/opensearch/test/engine/MockEngineSupport.java	1.86% <0.00%> (-61.69%)	⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java	0.00% <0.00%> (-60.00%)	⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java	31.00% <0.00%> (-45.00%)	⬇️
...opensearch/index/reindex/BulkByScrollResponse.java	48.38% <0.00%> (-38.71%)	⬇️
...earch/client/indices/GetIndexTemplatesRequest.java	38.46% <0.00%> (-34.62%)	⬇️
...ations/bucket/terms/heuristic/ScriptHeuristic.java	5.55% <0.00%> (-31.49%)	⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java	70.68% <0.00%> (-25.87%)	⬇️
... and 498 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 261814294b449e48d747f35688e4aaaf515784fe
# Push it to GitHub
git push --set-upstream origin backport/backport-6063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6063-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6063-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 261814294b449e48d747f35688e4aaaf515784fe
# Push it to GitHub
git push --set-upstream origin backport/backport-6063-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6063-to-2.x.