Refactor buffer interval code for remote-backed indexes (#6063)

Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 2618142) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Jan 30, 2023 · d4aa090 · d4aa090
1 parent 79dbd2b
commit d4aa090
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessor.java b/server/src/main/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessor.java
@@ -57,7 +57,7 @@ public void put(Item item, Consumer<Exception> listener) {
     private void scheduleProcess() {
         if (getQueue().isEmpty() == false && getPromiseSemaphore().tryAcquire()) {
             try {
-                threadpool.schedule(this::process, getBufferInterval(), getBufferRefreshThreadPoolName());
+                threadpool.schedule(this::process, getBufferInterval(), getBufferProcessThreadPoolName());
             } catch (Exception e) {
                 getLogger().error("failed to schedule process");
                 processSchedulingFailure(e);
@@ -88,6 +88,6 @@ private TimeValue getBufferInterval() {
         return TimeValue.timeValueNanos(bufferInterval.getNanos() - timeSinceLastRunStartInNS);
     }
 
-    protected abstract String getBufferRefreshThreadPoolName();
+    protected abstract String getBufferProcessThreadPoolName();
 
 }
diff --git a/server/src/main/java/org/opensearch/index/shard/IndexShard.java b/server/src/main/java/org/opensearch/index/shard/IndexShard.java
@@ -3855,7 +3855,7 @@ protected void write(List<Tuple<Translog.Location, Consumer<Exception>>> candida
                 }
 
                 @Override
-                protected String getBufferRefreshThreadPoolName() {
+                protected String getBufferProcessThreadPoolName() {
                     return ThreadPool.Names.TRANSLOG_SYNC;
                 }
             };

diff --git a/...er/src/test/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessorTests.java b/...er/src/test/java/org/opensearch/common/util/concurrent/BufferedAsyncIOProcessorTests.java
@@ -66,7 +66,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
             }
 
             @Override
-            protected String getBufferRefreshThreadPoolName() {
+            protected String getBufferProcessThreadPoolName() {
                 return ThreadPool.Names.TRANSLOG_SYNC;
             }
         };
@@ -108,7 +108,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
             }
 
             @Override
-            protected String getBufferRefreshThreadPoolName() {
+            protected String getBufferProcessThreadPoolName() {
                 return ThreadPool.Names.TRANSLOG_SYNC;
             }
         };
@@ -164,7 +164,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
             }
 
             @Override
-            protected String getBufferRefreshThreadPoolName() {
+            protected String getBufferProcessThreadPoolName() {
                 return ThreadPool.Names.TRANSLOG_SYNC;
             }
         };
@@ -229,7 +229,7 @@ protected void write(List<Tuple<Object, Consumer<Exception>>> candidates) throws
             }
 
             @Override
-            protected String getBufferRefreshThreadPoolName() {
+            protected String getBufferProcessThreadPoolName() {
                 return ThreadPool.Names.TRANSLOG_SYNC;
             }
         };