Fix a bug on handling an invalid array value for point type field

[heemin32]

With this commit, appropriate exception is thrown when an array of four values are provided for point type field.

Signed-off-by: Heemin Kim [email protected]

Description

#4597 introduced a bug which accept an array of four values for point type field. This PR resolve the issue.

Current behavior:

PUT testindex1/_doc/4
{
  "point": [1.1, 1.2, 1.3, 1.4] 
}

200 OK

Expected behavior after this commit:

PUT testindex1/_doc/4
{
  "point": [1.1, 1.2, 1.3, 1.4] 
}

400 [geo_point] field type does not accept more than 3 values

Issues Resolved

N/A

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5497/
• CommitID: 7724302
  Please examine the workflow log, locate, and copy-paste the failure below.
  Flakey test?
  Iterate to green.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5498/
• CommitID: 7485f4a

[codecov-commenter]

Codecov Report

Merging #4900 (7485f4a) into main (67a29df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4900      +/-   ##
============================================
- Coverage     70.74%   70.73%   -0.02%     
- Complexity    57859    57865       +6     
============================================
  Files          4689     4689              
  Lines        276913   276913              
  Branches      40301    40301              
============================================
- Hits         195912   195867      -45     
- Misses        64780    64875      +95     
+ Partials      16221    16171      -50     

Impacted Files	Coverage Δ
...index/mapper/AbstractPointGeometryFieldMapper.java	93.13% <100.00%> (+1.96%)	⬆️
...g/opensearch/index/analysis/CharFilterFactory.java	0.00% <0.00%> (-100.00%)	⬇️
...r/src/main/java/org/opensearch/http/HttpUtils.java	16.66% <0.00%> (-50.00%)	⬇️
...nsearch/rest/action/cat/RestCatRecoveryAction.java	43.61% <0.00%> (-42.56%)	⬇️
.../java/org/opensearch/search/dfs/AggregatedDfs.java	54.83% <0.00%> (-41.94%)	⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java	60.00% <0.00%> (-40.00%)	⬇️
...ava/org/opensearch/search/dfs/DfsSearchResult.java	46.87% <0.00%> (-38.55%)	⬇️
...luster/routing/allocation/RoutingExplanations.java	62.06% <0.00%> (-37.94%)	⬇️
...pensearch/action/ingest/DeletePipelineRequest.java	31.25% <0.00%> (-37.50%)	⬇️
...cluster/routing/allocation/RerouteExplanation.java	70.00% <0.00%> (-30.00%)	⬇️
... and 476 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4900-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0f477a2d0aae4d75313a7f26407cda8594bd981e
# Push it to GitHub
git push --set-upstream origin backport/backport-4900-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4900-to-2.x.