-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of GeoJson Point for GeoPoint field #4597
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/common/geo/PointParserTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/common/geo/PointParserTests.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/common/geo/PointParserTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/common/geo/PointParserTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/common/geo/PointParserTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/geo/PointParser.java
Outdated
Show resolved
Hide resolved
Will raise another commit with more unit tests in GeoPointFieldMapperTests. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thx!
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4597-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a282d399225247226d5abc3e3cd903462c973877
# Push it to GitHub
git push --set-upstream origin backport/backport-4597-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@heemin32 will need a manual backport to 2.x if you want this in a 2.x release |
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39)
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39)
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39)
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39)
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39)
) * Support of GeoJson Point for GeoPoint field (#4597) * Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit a282d39) * Run geojson yaml test for 2.4 and above only Signed-off-by: Heemin Kim <[email protected]> Signed-off-by: Heemin Kim <[email protected]>
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> * Refactored code based on comments Signed-off-by: Heemin Kim <[email protected]> * Add unit tests for GeoJson support Signed-off-by: Heemin Kim <[email protected]> * Resolve comments * Remove negation expression * Ignore case for GeoJson Point type to be consistent with geo_shape parsing Signed-off-by: Heemin Kim <[email protected]> * Added yaml test for geopoint Signed-off-by: Heemin Kim <[email protected]> Signed-off-by: Heemin Kim <[email protected]>
* Support of GeoJson Point for GeoPoint field See opensearch-project/geospatial#152 Signed-off-by: Heemin Kim <[email protected]> * Refactored code based on comments Signed-off-by: Heemin Kim <[email protected]> * Add unit tests for GeoJson support Signed-off-by: Heemin Kim <[email protected]> * Resolve comments * Remove negation expression * Ignore case for GeoJson Point type to be consistent with geo_shape parsing Signed-off-by: Heemin Kim <[email protected]> * Added yaml test for geopoint Signed-off-by: Heemin Kim <[email protected]> Signed-off-by: Heemin Kim <[email protected]>
See opensearch-project/geospatial#152
Signed-off-by: Heemin Kim [email protected]
Description
Supports GeoJson Point type in GeoPoint field
Issues Resolved
opensearch-project/geospatial#152
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.