Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test for codecov #3839

Closed
wants to merge 2 commits into from
Closed

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Jul 10, 2022

Signed-off-by: Suraj Singh [email protected]

Description

The change is to ensure post enabling code coverage the PRs have appropriate bot comment for code coverage.

Issues Resolved

#1324

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <[email protected]>
@dreamer-89 dreamer-89 requested review from a team and reta as code owners July 10, 2022 18:37
@dreamer-89 dreamer-89 marked this pull request as draft July 10, 2022 18:47
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #3839 (c76cad4) into main (bfac8fc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3839      +/-   ##
============================================
- Coverage     70.52%   70.49%   -0.04%     
+ Complexity    56655    56610      -45     
============================================
  Files          4557     4557              
  Lines        272682   272682              
  Branches      40038    40038              
============================================
- Hits         192310   192215      -95     
- Misses        64203    64223      +20     
- Partials      16169    16244      +75     
Impacted Files Coverage Δ
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-44.00%) ⬇️
...nsearch/rest/action/cat/RestCatRecoveryAction.java 43.61% <0.00%> (-42.56%) ⬇️
.../search/aggregations/pipeline/HoltLinearModel.java 20.33% <0.00%> (-42.38%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...ion/admin/cluster/node/info/PluginsAndModules.java 53.12% <0.00%> (-34.38%) ⬇️
...search/search/aggregations/pipeline/EwmaModel.java 24.44% <0.00%> (-33.34%) ⬇️
...ter/coordination/CoordinationStateTestCluster.java 73.17% <0.00%> (-23.18%) ⬇️
...a/org/opensearch/transport/netty4/Netty4Utils.java 42.42% <0.00%> (-21.22%) ⬇️
...ations/bucket/terms/heuristic/ScriptHeuristic.java 5.55% <0.00%> (-20.38%) ⬇️
...n/java/org/opensearch/test/rest/yaml/Features.java 60.00% <0.00%> (-20.00%) ⬇️
... and 444 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfac8fc...c76cad4. Read the comment docs.

@dblock
Copy link
Member

dblock commented Jul 11, 2022

Can we close this?

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the awaitsFix referencing an unrelated PR?

@dreamer-89
Copy link
Member Author

Why is the awaitsFix referencing an unrelated PR?

Thanks @nknize for checking this. Yes, this change is unrelated to codecov.
Actually, in first iteration I wanted to see existing structure of codecov bot comment and thus pulled in change (random) from a different PR. I will update this soon.

@dreamer-89 dreamer-89 closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants