Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status check of code coverage for pull requests #1324

Closed
tlfeng opened this issue Sep 30, 2021 · 0 comments
Closed

Add status check of code coverage for pull requests #1324

tlfeng opened this issue Sep 30, 2021 · 0 comments
Assignees
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test

Comments

@tlfeng
Copy link
Collaborator

tlfeng commented Sep 30, 2021

Is your feature request related to a problem? Please describe.
A part of issue: #850
Depends on issue: #1320
A mechanism should be imported to ensure the code coverage of the repository keeps an acceptable level, and even keep improving.

Describe the solution you'd like
Add the Codecov status check in Pull Requests to indicate the percentage of code coverage of the repository after the code changes. We could even set preventing the PR being merged if the code coverage requirement isn't met.
It has been in the plan for OpenSearch/Dashboards plugins to add PR checks for code coverage, and we can expend it to OpenSearch.

Steps to add the status check:
Please refer to the guide in opensearch-plugins repo, and the Codecov docs

Describe alternatives you've considered
Examine code coverage report periodically instead of in every Pull Requests, and send notification if the code coverage difference beyond a threshold before and after a commit.

Additional context
None.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request discuss Issues intended to help drive brainstorming and decision making labels Sep 30, 2021
@tlfeng tlfeng added the :test Adding or fixing a test label Sep 30, 2021
@dreamer-89 dreamer-89 self-assigned this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request :test Adding or fixing a test
Projects
None yet
Development

No branches or pull requests

2 participants