fix gradle check failure caused by init of EngineConfig

[Poojita-Raj]

Signed-off-by: Poojita Raj [email protected]

Description

Fixes the failing tests caused by incorrect initialization of engineConfig in -

1. EngineTestCase
2. RefreshListenerTests

Issues Resolved

Failure mentioned in issue #2414

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

❌   Gradle Check failure 04a96171f307fa5243a63f44dde61215b67a910e
Log 3897

Reports 3897

[kartg]

The Gradle failure suggests that this change may be needed in other places as well.

I see that all of the tests in RefreshListenersTests have failed. This class creates an EngineConfig instance and also sets isReadOnly to true assuming it is isPrimary

Maybe this change is needed in more classes?

[Poojita-Raj]

The Gradle failure suggests that this change may be needed in other places as well.

I see that all of the tests in RefreshListenersTests have failed. This class creates an EngineConfig instance and also sets isReadOnly to true assuming it is isPrimary

Maybe this change is needed in more classes?

Good catch Kartik! I was only focused on the failure in the last gradle check failure log and missed this, made the changes as suggested now

[opensearch-ci-bot]

❌   Gradle Check failure 6194e19
Log 3907

Reports 3907