Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Reject Resize index requests during Remote Store Migration #13147

Merged

Conversation

astute-decipher
Copy link
Contributor

Description

Backport/backport #12686 to 2.x

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@astute-decipher astute-decipher changed the base branch from main to 2.x April 10, 2024 11:37
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Compatibility status:

Checks if related components are compatible with change 8a6b24b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

✅ Gradle check result for 5f6730d: SUCCESS

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.29%. Comparing base (0dd892c) to head (8a6b24b).
Report is 131 commits behind head on 2.x.

Files Patch % Lines
...on/admin/indices/shrink/TransportResizeAction.java 46.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13147      +/-   ##
============================================
+ Coverage     71.28%   71.29%   +0.01%     
- Complexity    60145    60664     +519     
============================================
  Files          4957     5003      +46     
  Lines        282799   285239    +2440     
  Branches      41409    41701     +292     
============================================
+ Hits         201591   203369    +1778     
- Misses        64189    64743     +554     
- Partials      17019    17127     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubh Sahu <[email protected]>
Copy link
Contributor

❕ Gradle check result for 8a6b24b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna changed the title Backport/backport 12686 to 2.x [Backport 2.x] Reject Resize index requests during Remote Store Migration Apr 15, 2024
@gbbafna gbbafna merged commit c24a208 into opensearch-project:2.x Apr 15, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants