-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject Resize index requests. (i.e, split, shrink and… #12686
Reject Resize index requests. (i.e, split, shrink and… #12686
Conversation
… clone, While migration is in progress Signed-off-by: Shubh Sahu <[email protected]>
❌ Gradle check result for c9b0487: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shubh Sahu <[email protected]>
Compatibility status:Checks if related components are compatible with change 06ae8c0 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 4548951: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…tion Signed-off-by: Shubh Sahu <[email protected]>
❌ Gradle check result for 6672cbe: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shubh Sahu <[email protected]>
❕ Gradle check result for ace7752: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12686 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.04%
- Complexity 59978 60431 +453
============================================
Files 4985 5026 +41
Lines 282275 284463 +2188
Branches 40946 41200 +254
============================================
+ Hits 201603 203306 +1703
- Misses 63999 64340 +341
- Partials 16673 16817 +144 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubh Sahu <[email protected]>
❌ Gradle check result for f262296: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shubh Sahu <[email protected]>
❌ Gradle check result for 872f742: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...rc/internalClusterTest/java/org/opensearch/remotemigration/ResizeIndexMigrationTestCase.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes mostly LGTM. Please address the minor comments
❌ Gradle check result for abf1be0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shubh Sahu <[email protected]>
abf1be0
to
60c77ea
Compare
❌ Gradle check result for 60c77ea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
… into serengity_personel
❕ Gradle check result for 2789f8c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/indices/shrink/TransportResizeAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubh Sahu <[email protected]>
❌ Gradle check result for c4f2530: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Changes looks good to me . Please fix spotless issues and fix the build |
Signed-off-by: Shubh Sahu <[email protected]>
… into serengity_personel
c4f2530
to
c99e50b
Compare
❌ Gradle check result for c99e50b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shubh Sahu <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12686-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ab31f55e88cc2d023cad6e60a15a0e0e87dac38
# Push it to GitHub
git push --set-upstream origin backport/backport-12686-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…13147) Signed-off-by: Shubh Sahu <[email protected]> (cherry picked from commit 9ab31f5)
…h-project#12686) Signed-off-by: Shubh Sahu <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
… clone), While DocRep to SegRep migration is in progress.
Description
We want to disallow some APIs' which are involved in Index resizing and shard relocation, when Document-Replication type to Segment-Replication type migration is happening.
SETTING_REMOTE_STORE_ENABLED
astrue
.REMOTE_STORE_COMPATIBILITY_MODE_SETTING
asMIXED
andMIGRATION_DIRECTION_SETTING
asREMOTE_STORE
and Condition 1 is not met.Related Issues
Resolves #12976
Check List
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.