Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject Resize index requests. (i.e, split, shrink and… #12686

Merged
merged 12 commits into from
Apr 4, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented Mar 15, 2024

… clone), While DocRep to SegRep migration is in progress.

Description

We want to disallow some APIs' which are involved in Index resizing and shard relocation, when Document-Replication type to Segment-Replication type migration is happening.

  1. Always allow if source Index setting/metadata has SETTING_REMOTE_STORE_ENABLED as true.
  2. Disallow If cluster settings has REMOTE_STORE_COMPATIBILITY_MODE_SETTING as MIXED and MIGRATION_DIRECTION_SETTING as REMOTE_STORE and Condition 1 is not met.

Related Issues

Resolves #12976

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… clone, While migration is in progress

Signed-off-by: Shubh Sahu <[email protected]>
Copy link
Contributor

❌ Gradle check result for c9b0487: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Compatibility status:

Checks if related components are compatible with change 06ae8c0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 4548951: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6672cbe:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ace7752: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.47%. Comparing base (b15cb0c) to head (06ae8c0).
Report is 132 commits behind head on main.

Files Patch % Lines
...on/admin/indices/shrink/TransportResizeAction.java 46.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12686      +/-   ##
============================================
+ Coverage     71.42%   71.47%   +0.04%     
- Complexity    59978    60431     +453     
============================================
  Files          4985     5026      +41     
  Lines        282275   284463    +2188     
  Branches      40946    41200     +254     
============================================
+ Hits         201603   203306    +1703     
- Misses        63999    64340     +341     
- Partials      16673    16817     +144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astute-decipher astute-decipher requested a review from linuxpi March 28, 2024 04:56
Copy link
Contributor

github-actions bot commented Apr 1, 2024

❌ Gradle check result for f262296: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 1, 2024

❌ Gradle check result for 872f742: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@shourya035 shourya035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly LGTM. Please address the minor comments

Copy link
Contributor

github-actions bot commented Apr 2, 2024

❌ Gradle check result for abf1be0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 3, 2024

❌ Gradle check result for 60c77ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 3, 2024

❕ Gradle check result for 2789f8c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@astute-decipher astute-decipher marked this pull request as ready for review April 3, 2024 10:09
Signed-off-by: Shubh Sahu <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for c4f2530: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Copy link
Collaborator

gbbafna commented Apr 4, 2024

Changes looks good to me . Please fix spotless issues and fix the build

Shubh Sahu added 2 commits April 4, 2024 11:00
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for c99e50b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 4, 2024

✅ Gradle check result for c99e50b: SUCCESS

Signed-off-by: Shubh Sahu <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

✅ Gradle check result for 06ae8c0: SUCCESS

@gbbafna gbbafna merged commit 9ab31f5 into opensearch-project:main Apr 4, 2024
30 of 31 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Apr 4, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12686-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ab31f55e88cc2d023cad6e60a15a0e0e87dac38
# Push it to GitHub
git push --set-upstream origin backport/backport-12686-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12686-to-2.x.

@gbbafna gbbafna mentioned this pull request Apr 4, 2024
21 tasks
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Remote labels Apr 8, 2024
gbbafna pushed a commit that referenced this pull request Apr 15, 2024
@astute-decipher astute-decipher self-assigned this Apr 21, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Storage:Remote
Projects
Status: ✅ Done
3 participants