Fix flaky SearchScrollWithFailingNodesIT

[andrross]

The test intended to stop a data node and called a method named stopRandomNonClusterManagerNode() in order to do that. However, that method would stop a random node that was not the currently elected cluster manager, regardless of node role. I have also renamed that method hoping to be more clear.

Resolves #10137

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• GitHub issue/PR created in OpenSearch documentation repo for the required public documentation changes (#[Issue/PR number])

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change e8fc524

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsOnRemoteStoreRestore

• URL: https://build.ci.opensearch.org/job/gradle-check/27012/
• CommitID: 505456a
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10374 (505456a) into main (22ddcf1) will decrease coverage by 0.18%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 505456a differs from pull request most recent head e8fc524. Consider uploading reports for the commit e8fc524 to get more accurate results

@@             Coverage Diff              @@
##               main   #10374      +/-   ##
============================================
- Coverage     71.28%   71.11%   -0.18%     
+ Complexity    58480    58288     -192     
============================================
  Files          4843     4830      -13     
  Lines        275265   274840     -425     
  Branches      40076    40048      -28     
============================================
- Hits         196227   195455     -772     
- Misses        62621    63030     +409     
+ Partials      16417    16355      -62     

see 524 files with indirect coverage changes

[dblock]

We should have a name for nodes that aren't current cluster manager, like a "worker" node to avoid things like RandomNonMasterNodeNotCurrentClusterManagerFactoryResolverAdapterFunctor class names ;)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

• URL: https://build.ci.opensearch.org/job/gradle-check/27488/
• CommitID: e8fc524
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.