Skip to content

Commit

Permalink
Fix flaky SearchScrollWithFailingNodesIT (opensearch-project#10374)
Browse files Browse the repository at this point in the history
The test intended to stop a data node and called a method named
`stopRandomNonClusterManagerNode()` in order to do that. However, that
method would stop a random node that was not the currently elected
cluster manager, regardless of node role. I have also renamed that
method hoping to be more clear.

Resolves opensearch-project#10137

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
  • Loading branch information
andrross authored and shiv0408 committed Apr 25, 2024
1 parent 699d462 commit a858c5a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ public void testThreeNodesNoClusterManagerBlock() throws Exception {
);
Settings nonClusterManagerDataPathSettings1 = internalCluster().dataPathSettings(nonClusterManagerNodes.get(0));
Settings nonClusterManagerDataPathSettings2 = internalCluster().dataPathSettings(nonClusterManagerNodes.get(1));
internalCluster().stopRandomNonClusterManagerNode();
internalCluster().stopRandomNonClusterManagerNode();
internalCluster().stopRandomNodeNotCurrentClusterManager();
internalCluster().stopRandomNodeNotCurrentClusterManager();

logger.info("--> verify that there is no cluster-manager anymore on remaining node");
// spin here to wait till the state is set
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void testClusterJoinDespiteOfPublishingIssues() throws Exception {

// shutting down the nodes, to avoid the leakage check tripping
// on the states associated with the commit requests we may have dropped
internalCluster().stopRandomNonClusterManagerNode();
internalCluster().stopRandomNodeNotCurrentClusterManager();
}

public void testClusterFormingWithASlowNode() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public void testScanScrollWithShardExceptions() throws Exception {
assertThat(numHits, equalTo(100L));
clearScroll("_all");

internalCluster().stopRandomNonClusterManagerNode();
internalCluster().stopRandomDataNode();

searchResponse = client().prepareSearch().setQuery(matchAllQuery()).setSize(10).setScroll(TimeValue.timeValueMinutes(1)).get();
assertThat(searchResponse.getSuccessfulShards(), lessThan(searchResponse.getTotalShards()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ public synchronized void stopCurrentClusterManagerNode() throws IOException {
/**
* Stops any of the current nodes but not the cluster-manager node.
*/
public synchronized void stopRandomNonClusterManagerNode() throws IOException {
public synchronized void stopRandomNodeNotCurrentClusterManager() throws IOException {
NodeAndClient nodeAndClient = getRandomNodeAndClient(new NodeNamePredicate(getClusterManagerName()).negate());
if (nodeAndClient != null) {
logger.info(
Expand All @@ -1841,11 +1841,11 @@ public synchronized void stopCurrentMasterNode() throws IOException {
/**
* Stops any of the current nodes but not the cluster-manager node.
*
* @deprecated As of 2.2, because supporting inclusive language, replaced by {@link #stopRandomNonClusterManagerNode()}
* @deprecated As of 2.2, because supporting inclusive language, replaced by {@link #stopRandomNodeNotCurrentClusterManager()}
*/
@Deprecated
public synchronized void stopRandomNonMasterNode() throws IOException {
stopRandomNonClusterManagerNode();
public synchronized void stopRandomNodeNotCurrentMaster() throws IOException {
stopRandomNodeNotCurrentClusterManager();
}

/**
Expand All @@ -1860,7 +1860,7 @@ public void stopAllNodes() {
}
int totalClusterManagerNodes = numClusterManagerNodes();
while (totalClusterManagerNodes > 1) {
stopRandomNonClusterManagerNode();
stopRandomNodeNotCurrentClusterManager();
totalClusterManagerNodes -= 1;
}
stopCurrentClusterManagerNode();
Expand Down

0 comments on commit a858c5a

Please sign in to comment.