Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]Refactor: flatten left nav in Analytics(all) use case #8332

Merged
merged 41 commits into from
Oct 3, 2024

feat: optimize code based on comments

a10cb84
Select commit
Loading
Failed to load commit list.
Merged

[navigation]Refactor: flatten left nav in Analytics(all) use case #8332

feat: optimize code based on comments
a10cb84
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 1s

60.93% (-0.01%) compared to 774909e

View this Pull Request on Codecov

60.93% (-0.01%) compared to 774909e

Details

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (774909e) to head (a10cb84).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
.../core/public/chrome/nav_group/nav_group_service.ts 80.00% 1 Missing and 5 partials ⚠️
...public/chrome/ui/header/collapsible_nav_groups.tsx 55.55% 1 Missing and 3 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 60.00% 0 Missing and 2 partials ⚠️
.../chrome/ui/header/collapsible_nav_groups_label.tsx 86.66% 1 Missing and 1 partial ⚠️
.../public/components/feature_cards/feature_cards.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8332      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3756     3759       +3     
  Lines       89225    89323      +98     
  Branches    13950    13970      +20     
==========================================
+ Hits        54373    54432      +59     
- Misses      31469    31494      +25     
- Partials     3383     3397      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov