Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]Refactor: flatten left nav in Analytics(all) use case #8332

Merged
merged 41 commits into from
Oct 3, 2024

feat: optimize code based on comments

a10cb84
Select commit
Loading
Failed to load commit list.
Merged

[navigation]Refactor: flatten left nav in Analytics(all) use case #8332

feat: optimize code based on comments
a10cb84
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 3, 2024 in 1s

80.76% of diff hit (target 60.93%)

View this Pull Request on Codecov

80.76% of diff hit (target 60.93%)

Annotations

Check warning on line 166 in src/core/public/chrome/nav_group/nav_group_service.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/core/public/chrome/nav_group/nav_group_service.ts#L166

Added line #L166 was not covered by tests

Check warning on line 171 in src/core/public/chrome/ui/header/collapsible_nav_groups.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/core/public/chrome/ui/header/collapsible_nav_groups.tsx#L171

Added line #L171 was not covered by tests

Check warning on line 37 in src/core/public/chrome/ui/header/collapsible_nav_groups_label.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/core/public/chrome/ui/header/collapsible_nav_groups_label.tsx#L37

Added line #L37 was not covered by tests