Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Keyboard shortcut for running queries #8322

Merged
merged 12 commits into from
Oct 4, 2024
Merged

[Enhancement] Keyboard shortcut for running queries #8322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6d6e170
added keyboard listener
sumukhswamy Sep 24, 2024
80ef82c
Merge branch 'main' into keyboard-shortcut
sumukhswamy Sep 25, 2024
a1d1b62
changed implementation to monaco action button
sumukhswamy Sep 25, 2024
ec4cdff
changed implementation to monaco action button
sumukhswamy Sep 25, 2024
2b22fe5
added space
sumukhswamy Sep 25, 2024
32ac4d4
Merge branch 'main' into keyboard-shortcut
sumukhswamy Sep 30, 2024
2ea4a91
Update src/plugins/data/public/ui/query_editor/query_editor.tsx
sumukhswamy Oct 1, 2024
e277edd
Merge branch 'main' into keyboard-shortcut
sumukhswamy Oct 1, 2024
ace2619
updated linter, added changesheet
sumukhswamy Oct 1, 2024
82c7808
Merge branch 'main' into keyboard-shortcut
sumukhswamy Oct 1, 2024
900e312
Merge branch 'main' into keyboard-shortcut
sumukhswamy Oct 2, 2024
8e8bc65
Merge branch 'main' into keyboard-shortcut
sumukhswamy Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/8322.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Keyboard shortcut for running queries ([#8322](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8322))
8 changes: 8 additions & 0 deletions src/plugins/data/public/ui/query_editor/query_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,14 @@ export default class QueryEditorUI extends Component<Props, State> {
editor.setValue(`\n`.repeat(10));
this.setState({ lineCount: editor.getModel()?.getLineCount() });
this.inputRef = editor;
// eslint-disable-next-line no-bitwise
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter, () => {
this.onSubmit(this.props.query);
});

return () => {
disposable.dispose();
};
},
footerItems: {
start: [
Expand Down
Loading