[Enhancement] Keyboard shortcut for running queries #8322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 8322.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8322 +/- ##
=======================================
Coverage 60.94% 60.94%
=======================================
Files 3759 3759
Lines 89329 89329
Branches 13973 13973
=======================================
Hits 54438 54438
Misses 31494 31494
Partials 3397 3397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
reviewed
Sep 24, 2024
| @@ -72,6 +72,20 @@ export default function QueryEditorTopRow(props: QueryEditorTopRowProps) { | |||
| }, | |||
| } = opensearchDashboards.services; | |||
|
|
|||
| useEffect(() => { | |||
| function handleCmdEnter(event: KeyboardEvent) { | |||
There was a problem hiding this comment.
I think we could use
this.inputRef which is the Monaco Editor ref and add an action like this
There was a problem hiding this comment.
Have updated it
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
ashwin-pc
reviewed
Oct 1, 2024
|
@sumukhswamy can we add a changeset file here? |
Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
ashwin-pc
approved these changes
Oct 1, 2024
sejli
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* added keyboard listener Signed-off-by: sumukhswamy <[email protected]> * changed implementation to monaco action button Signed-off-by: sumukhswamy <[email protected]> * changed implementation to monaco action button Signed-off-by: sumukhswamy <[email protected]> * added space Signed-off-by: sumukhswamy <[email protected]> * Update src/plugins/data/public/ui/query_editor/query_editor.tsx Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]> * updated linter, added changesheet Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 57eea79) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Oct 18, 2024
* added keyboard listener * changed implementation to monaco action button * changed implementation to monaco action button * added space * Update src/plugins/data/public/ui/query_editor/query_editor.tsx * updated linter, added changesheet --------- (cherry picked from commit 57eea79) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cmd+enter functionality runs the query in the editor
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration