Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Workspace]Fix workspace detail classname definition #7986

Merged
merged 5 commits into from
Sep 4, 2024
Merged

[Bug] [Workspace]Fix workspace detail classname definition #7986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7640ef6
update css defination class name
yubonluo Sep 4, 2024
a504ca9
optimize the code
yubonluo Sep 4, 2024
0b2ef8c
optimize the code
yubonluo Sep 4, 2024
f60db7f
Merge branch '2.17/fix-css-bug' of github.com:yubonluo/OpenSearch-Das…
yubonluo Sep 4, 2024
d2b2f03
Changeset file for PR #7986 created/updated
opensearch-changeset-bot[bot] Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7986.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Fix workspace detail classname definition ([#7986](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7986))
10 changes: 5 additions & 5 deletions src/plugins/workspace/public/components/workspace_detail/data_source_connection_table.scss
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big issue, but what about applying BEM style css class name?

Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
.customized-table thead {
.workspace-detail-direct-query-expanded-table thead {
display: none;
}

[id^="row"][id$="expansion"] > td:first-child > div:first-child {
.workspace-detail-direct-query-table [id^="row"][id$="expansion"] > td:first-child > div:first-child {
padding: 0;
}

.customized-row:first-child > td {
.workspace-detail-direct-query-expanded-row:first-child > td {
border-top: 0;
}

.customized-row:last-child > td {
.workspace-detail-direct-query-expanded-row:last-child > td {
border-bottom: 0;
}

.customized-row > td:nth-child(2) {
.workspace-detail-direct-query-expanded-row > td:nth-child(2) {
padding-left: 25px;
}
5 changes: 3 additions & 2 deletions src/plugins/workspace/public/components/workspace_detail/data_source_connection_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ export const DataSourceConnectionTable = ({
items={item?.relatedConnections ?? []}
itemId="id"
columns={baseColumns}
className="customized-table"
className="workspace-detail-direct-query-expanded-table"
rowProps={{
className: 'customized-row',
className: 'workspace-detail-direct-query-expanded-row',
}}
/>
);
Expand Down Expand Up @@ -295,6 +295,7 @@ export const DataSourceConnectionTable = ({
isSelectable={true}
itemIdToExpandedRowMap={itemIdToExpandedRowMap}
isExpandable={true}
className="workspace-detail-direct-query-table"
pagination={{
initialPageSize: 10,
pageSizeOptions: [10, 20, 30],
Expand Down
Loading