-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] [Workspace]Fix workspace detail classname definition #7986
Conversation
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
…hboards into 2.17/fix-css-bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7986 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 3691 3691
Lines 87310 87310
Branches 13433 13433
=======================================
Hits 53340 53340
Misses 30722 30722
Partials 3248 3248
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big issue, but what about applying BEM style css class name?
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7986-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 95929a6af6cc7171d4c5ddb8f2dccb307bd07e98
# Push it to GitHub
git push --set-upstream origin backport/backport-7986-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
(cherry picked from commit 95929a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8018) (cherry picked from commit 95929a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 67aa197) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The previous code did not add a specific classname for
[id^="row"][id$="expansion"]
, which resulted the SCSS file affecting the global UI. Therefore, add a specific classname to it so that it only takes effect in the table in the workspace details section.Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration