-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataSource] Adding an optional setting that controls the permissions of data source to create/update/delete. #7091
[DataSource] Adding an optional setting that controls the permissions of data source to create/update/delete. #7091
Conversation
Signed-off-by: yubonluo <[email protected]>
…oards into 2.16-datasource-readonly
❌ Entry Too LongEntry is 110 characters long, which is 10 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7091 +/- ##
==========================================
+ Coverage 67.45% 67.48% +0.02%
==========================================
Files 3448 3449 +1
Lines 67916 67972 +56
Branches 11042 11054 +12
==========================================
+ Hits 45812 45870 +58
- Misses 19435 19480 +45
+ Partials 2669 2622 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/data_source/server/saved_objects/data_source_permission_client_wrapper.ts
Outdated
Show resolved
Hide resolved
src/plugins/data_source/server/saved_objects/data_source_permission_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
…arch-Dashboards into 2.16-datasource-readonly
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Convert to draft as we need to discuss. |
Description
Adding an optional setting that controls the permissions of data source to create/update/delete.
Issues Resolved
#6889
Screenshot
data_source.editMode: "read_only" or
data_source.editMode: "admin_only" and user is not OSD Admin
Create:
Upate:
Delete:
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration