Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataSource] Restrict data source creation/update/delete when manageableBy is none or dashboard_admin #6889

Closed
yubonluo opened this issue Jun 3, 2024 · 2 comments
Labels
enhancement New feature or request v2.16.0

Comments

@yubonluo
Copy link
Contributor

yubonluo commented Jun 3, 2024

Is your feature request related to a problem? Please describe.

Adding an optional setting that controls the permissions of data source to create, update and delete.
data_source.editMode: "read_only|admin_only|none"
"all": The data source is readonly for all users.
"dashboard_admin": The data source can only be managed by dashboard admin.((#6389) ).
"all": The data source can be managed by all users. Default to "all".

Describe the solution you'd like

Before editing a data source, data source permission client wrapper will verify the data source edit mode.

Describe alternatives you've considered

Additional context

#4944

@yubonluo yubonluo added the enhancement New feature or request label Jun 3, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 3, 2024

Hi @yubonluo, thanks for opening the issue! Are we targeting this in 2.16?

@yubonluo
Copy link
Contributor Author

yubonluo commented Jun 3, 2024

Hi @yubonluo, thanks for opening the issue! Are we targeting this in 2.16?

Hi @BionIT , The PR regarding this issue will be submitted in the next two days, with releasing on 2.15.

@BionIT BionIT added the v2.15.0 label Jun 3, 2024
@ruanyl ruanyl added v2.16.0 and removed v2.15.0 labels Jun 5, 2024
@yubonluo yubonluo changed the title [Workspace] Only OSD admin can create/update/delete data source [DataSource] Restrict data source creation/update/delete when editMode is read_only or admin_only Jun 24, 2024
@yubonluo yubonluo changed the title [DataSource] Restrict data source creation/update/delete when editMode is read_only or admin_only [DataSource] Restrict data source creation/update/delete when manageableBy is none or dashboard_admin Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.16.0
Projects
None yet
Development

No branches or pull requests

3 participants