Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Only OSD admin can create/update/delete data source #6901

Closed

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Jun 4, 2024

Description

Only OSD admin can create/update/delete data source

Issues Resolved

#6889

Screenshot

data-source-OSDAdmin.mp4

Testing the changes

  1. Clone the latest osd/security-dashboard plugin code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml
opensearchDashboards.dashboardAdmin.groups: ["dashboard_admin"]
opensearchDashboards.dashboardAdmin.users: ["username"]
workspace.enabled: true 
opensearch.username: "username"
opensearch.password: "password" 
opensearch.ssl.verificationMode: none
savedObjects.permission.enabled: true
data_source.enabled: true
  1. Run yarn start --no-base-path
  2. Operate data source.

Changelog

  • feat: [Workspace] Only OSD admin can create/update/delete data source

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

SuZhou-Joe
SuZhou-Joe previously approved these changes Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (e74ed2c) to head (47e9c65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6901      +/-   ##
==========================================
+ Coverage   67.45%   67.46%   +0.01%     
==========================================
  Files        3442     3442              
  Lines       67816    67845      +29     
  Branches    11027    11032       +5     
==========================================
+ Hits        45742    45773      +31     
+ Misses      19408    19407       -1     
+ Partials     2666     2665       -1     
Flag Coverage Δ
Linux_1 33.12% <100.00%> (+0.04%) ⬆️
Linux_2 55.11% <ø> (ø)
Linux_3 45.20% <ø> (ø)
Linux_4 34.86% <ø> (ø)
Windows_1 33.15% <100.00%> (+0.04%) ⬆️
Windows_2 55.06% <ø> (ø)
Windows_3 45.21% <ø> (ø)
Windows_4 34.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @yubonluo , is this PR targeting 2.15 or 2.16?

@yubonluo
Copy link
Contributor Author

yubonluo commented Jun 5, 2024

Hi @yubonluo , is this PR targeting 2.15 or 2.16?

Hi @BionIT this PR target 2.15.

@ruanyl ruanyl added v2.16.0 and removed v2.15.0 labels Jun 5, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

@ruanyl @yubonluo I saw the tag was changed to 2.16, just want to double check if it is correct

@yubonluo
Copy link
Contributor Author

yubonluo commented Jun 6, 2024

@ruanyl @yubonluo I saw the tag was changed to 2.16, just want to double check if it is correct
Hi @BionIT due to the need to confirm some additional requirements, the PR will be released on 2.16.

@yubonluo yubonluo closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants