-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Only OSD admin can create/update/delete data source #6901
Closed
yubonluo
wants to merge
7
commits into
opensearch-project:main
from
yubonluo:main-data-source-OSDAdmin
Closed
[Workspace] Only OSD admin can create/update/delete data source #6901
yubonluo
wants to merge
7
commits into
opensearch-project:main
from
yubonluo:main-data-source-OSDAdmin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
June 4, 2024 02:33
Signed-off-by: yubonluo <[email protected]>
SuZhou-Joe
previously approved these changes
Jun 4, 2024
…earch-Dashboards into main-data-source-OSDAdmin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6901 +/- ##
==========================================
+ Coverage 67.45% 67.46% +0.01%
==========================================
Files 3442 3442
Lines 67816 67845 +29
Branches 11027 11032 +5
==========================================
+ Hits 45742 45773 +31
+ Misses 19408 19407 -1
+ Partials 2666 2665 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @yubonluo , is this PR targeting 2.15 or 2.16? |
raintygao
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only OSD admin can create/update/delete data source
Issues Resolved
#6889
Screenshot
data-source-OSDAdmin.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration