Extract the button component for datasource picker to avoid duplicate code #6559

zhyuanqi · 2024-04-19T18:53:53Z

Description

Extract the button component for datasource picker to avoid duplicate code

Screenshot

Testing the changes

Add multiple datasources and click on button to see if it work as expected

Changelog

fix: Extract the button component for datasource picker to avoid duplicate code

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-04-19T18:54:26Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-04-19T18:54:49Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-04-19T19:11:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.80%. Comparing base (d2d410b) to head (ef0e997).
Report is 34 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6559       +/-   ##
===========================================
+ Coverage   32.93%   67.80%   +34.86%     
===========================================
  Files        2260     3411     +1151     
  Lines       45769    66740    +20971     
  Branches     7200    10860     +3660     
===========================================
+ Hits        15075    45251    +30176     
+ Misses      29984    18845    -11139     
- Partials      710     2644     +1934

Flag	Coverage Δ
Linux_1	`33.18% <ø> (+0.25%)`	⬆️
Linux_2	`55.63% <ø> (?)`
Linux_3	`45.22% <100.00%> (?)`
Linux_4	`34.91% <20.00%> (?)`
Windows_1	`33.23% <ø> (?)`
Windows_2	`55.59% <ø> (?)`
Windows_3	`45.24% <100.00%> (?)`
Windows_4	`34.91% <20.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

huyaboo · 2024-04-22T20:35:40Z

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

@@ -156,7 +157,7 @@ export class DataSourceView extends React.Component<DataSourceViewProps, DataSou
    if (this.state.showError) {
      return <DataSourceErrorMenu />;
    }
-    const label = this.state.selectedOption.length > 0 ? this.state.selectedOption[0].label : '';
+    const label = this.state.selectedOption.length > 0 ? this.state.selectedOption[0].label! : '';


Wouldn't label be undefined here at initial render of the component if consumers pass in [{id}]?

Good catch! Let me add check here

BionIT · 2024-04-23T00:13:43Z

src/plugins/data_source_management/public/components/popover_button/popover_button.tsx

+  onClick: () => void;
+}
+
+export const PopoverButton: React.FC<PopoverButtonProps> = ({ className, label, onClick }) => {


Can we use a more specific name, i.e. DataSourceMenuButton

BionIT · 2024-04-23T00:14:12Z

src/plugins/data_source_management/public/components/popover_button/popover_button.tsx

+  return (
+    <>
+      <EuiButtonEmpty
+        className={`dataSourceComponentButtonTitle`}


can we use the className passed down?

Yeah. It is the unified CSS selector to control the button length, make sure it does not exceed 16 ch. So will not need to pass down since it is unified among all pickers,

BionIT · 2024-04-24T19:39:35Z

src/plugins/data_source_management/public/components/popover_button/popover_button.tsx

+  onClick: () => void;
+}
+
+export const DataSourceMenuPopoverButton: React.FC<DataSourceMenuPopoverButtonProps> = ({


nit: can we change the file name as well?

… code Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

… code (#6559) * Extract the button component for datasource picker to avoid duplicate code Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Modify the name of popover button Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit b9ac31e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

… code (#6559) (#6645) * Extract the button component for datasource picker to avoid duplicate code Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Modify the name of popover button Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit b9ac31e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… code (opensearch-project#6559) * Extract the button component for datasource picker to avoid duplicate code Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Modify the name of popover button Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

zhyuanqi requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners April 19, 2024 18:53

github-actions bot added the valued-contributor label Apr 19, 2024

zhyuanqi changed the title ~~Extract the button component for datasource picker to avoid duplicate…~~ Extract the button component for datasource picker to avoid duplicate code Apr 19, 2024

github-actions bot added the failed changeset label Apr 19, 2024

github-actions bot removed the failed changeset label Apr 19, 2024

opensearch-changeset-bot bot added a commit to zhyuanqi/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024

Changeset file for PR opensearch-project#6559 created/updated

8f8f2c2

zhyuanqi pushed a commit to zhyuanqi/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024

Changeset file for PR opensearch-project#6559 created/updated

615fec3

zhyuanqi force-pushed the button-components branch from 8f8f2c2 to 615fec3 Compare April 19, 2024 18:56

zhyuanqi force-pushed the button-components branch 3 times, most recently from d2efc74 to 88ddd0d Compare April 19, 2024 22:38

zhyuanqi force-pushed the button-components branch from 88ddd0d to 959984d Compare April 22, 2024 17:10

huyaboo reviewed Apr 22, 2024

View reviewed changes

zhyuanqi force-pushed the button-components branch 2 times, most recently from f828569 to 878cecd Compare April 22, 2024 23:20

BionIT reviewed Apr 23, 2024

View reviewed changes

zhyuanqi force-pushed the button-components branch from 9813e86 to 904aca1 Compare April 24, 2024 05:57

BionIT added backport 2.x multiple datasource multiple datasource project labels Apr 24, 2024

huyaboo added the v2.14.0 label Apr 24, 2024

BionIT reviewed Apr 24, 2024

View reviewed changes

Extract the button component for datasource picker to avoid duplicate…

0c9e147

… code Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

zhyuanqi force-pushed the button-components branch from 35b62b4 to 57cb171 Compare April 25, 2024 17:45

Modify the name of popover button

91dbbac

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

zhyuanqi force-pushed the button-components branch from 57cb171 to 91dbbac Compare April 25, 2024 18:05

BionIT mentioned this pull request Apr 25, 2024

[Meta] [2.14] Security, bug fix and enhancemanet for dashboards anywhere #5872

Closed

77 tasks

Merge branch 'main' into button-components

ef0e997

BionIT approved these changes Apr 25, 2024

View reviewed changes

zhongnansu approved these changes Apr 25, 2024

View reviewed changes

zhongnansu merged commit b9ac31e into opensearch-project:main Apr 25, 2024
67 checks passed

opensearch-trigger-bot bot mentioned this pull request Apr 25, 2024

[Backport 2.x] Extract the button component for datasource picker to avoid duplicate code #6645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract the button component for datasource picker to avoid duplicate code #6559

Extract the button component for datasource picker to avoid duplicate code #6559

zhyuanqi commented Apr 19, 2024 •

edited

Loading

github-actions bot commented Apr 19, 2024

github-actions bot commented Apr 19, 2024

codecov bot commented Apr 19, 2024 •

edited

Loading

huyaboo Apr 22, 2024

zhyuanqi Apr 22, 2024

BionIT Apr 23, 2024

zhyuanqi Apr 23, 2024

BionIT Apr 23, 2024

zhyuanqi Apr 23, 2024

BionIT Apr 24, 2024

zhyuanqi Apr 24, 2024

Extract the button component for datasource picker to avoid duplicate code #6559

Extract the button component for datasource picker to avoid duplicate code #6559

Conversation

zhyuanqi commented Apr 19, 2024 • edited Loading

Description

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Apr 19, 2024

❌ Empty Changelog Section

github-actions bot commented Apr 19, 2024

❌ Empty Changelog Section

codecov bot commented Apr 19, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhyuanqi commented Apr 19, 2024 •

edited

Loading

codecov bot commented Apr 19, 2024 •

edited

Loading